fix: handle package name without dot to prevent index out of range#78
Open
yashisrani wants to merge 1 commit into
Open
fix: handle package name without dot to prevent index out of range#78yashisrani wants to merge 1 commit into
yashisrani wants to merge 1 commit into
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a potential index out of range panic in
wrap/grpc.gowhen parsing proto files where the package name doesn't contain a dot.Problem
When
packageNamehas no dot (e.g.,"mypackage"),strings.LastIndexreturns-1, causingpackageName[lastPiece+1:]to slice incorrectly and produce wrong output.Solution
Added a check for
lastPiece == -1to handle package names without dots, ensuring correct slice indexing in all cases.Changes
wrap/grpc.go:471-478- Fixed import alias extraction logicTesting