refactor: remove internal/layout/Engine (ADR-032 CACHE-030)#163
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…ACHE-030) Engine (centralized layout cache) has 0 production usage — confirmed by codebase audit. Per-widget layout caching is now handled by widget.LayoutChild on WidgetBase (ADR-032 Phase 2b, #160). - Delete engine.go + engine_test.go (-769 LOC) - Extract Layoutable interface to layoutable.go (used by Flex/Grid/Stack) - Extract mockLayoutable to mock_test.go - Remove Engine cache benchmarks from bench_test.go - Update doc.go and CHANGELOG
kolkov
force-pushed
the
chore/cache-030-031-cleanup
branch
from
July 5, 2026 10:26
18341e6 to
e5a9175
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
internal/layout/Engine— centralized layout cache with 0 production usage (confirmed by codebase audit). Per-widget layout caching is now fully handled bywidget.LayoutChildonWidgetBase(ADR-032 Phase 2b, #160).-769 lines of dead code removed.
Changes
engine.go+engine_test.goLayoutableinterface tolayoutable.go(still used by Flex/Grid/Stack)mockLayoutabletomock_test.go(still used by layout tests)bench_test.godoc.go: remove Engine references, add LayoutChild noteTest plan
go build ./...go test ./... -count=1(all pass)golangci-lint run --timeout=5m(0 issues)