fix(vk-gen): C array params + deterministic output (v0.30.18)#250
Merged
Conversation
vkCmdSetBlendConstants(const float[4]) was called with SigVoidHandleF32 (scalar float CIF) instead of SigVoidHandlePtr (pointer CIF). C arrays in function params decay to pointers — generator now detects '[' in RawXML and classifies as 'ptr' with double-pointer arg pattern. Also fixes non-deterministic const_gen.go output: extension enum map keys are now sorted before iteration (Go map order is random). Fixes Vulkan crash on Windows (CmdSetBlendConstants). Regression from vk-gen regeneration in v0.30.17 which overwrote manual fix.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vkCmdSetBlendConstants(const float[4])generated with wrong CIF (scalar float instead of pointer). C array params decay to pointers in C ABI.CmdSetFragmentShadingRateKHRandCmdSetFragmentShadingRateEnumNV— same array param issue (combinerOps[2])const_gen.gooutput — sorted map keys for extension enums (was 1780+ line noise diffs on every regeneration)Test plan
go build ./...— Windows, Linux, macOSgo test ./...— 15/15 passgolangci-lint run— 0 issuesgofmt -l .— 0 unformatted