fix(core): PresentPixels check-before-mutate + docs (v0.30.20)#255
Merged
Conversation
…ture Move hal.PixelPresenter type assertion before acquired texture discard. Failed PresentPixels call on GPU backends no longer corrupts surface state — acquired texture preserved for normal render→Present fallback. Validate-then-mutate pattern matches Rust wgpu Surface::present() and configure_surface() precondition checks.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hal.PixelPresentertype assertion before acquired texture discard. Failed call on GPU backends no longer corrupts surface state. Validated against Rust wgpu Surface state machine.Test plan
go test ./core/...— passTestPresentPixels_PreservesAcquiredOnUnsupported— verifies state preserved