fix(vulkan): reject pipelines without layouts#257
Open
besmpl wants to merge 1 commit into
Open
Conversation
besmpl
force-pushed
the
codex/upstream-vulkan-layout
branch
from
58e5fe2 to
c59271f
Compare
besmpl
force-pushed
the
codex/upstream-vulkan-layout
branch
from
c59271f to
2209496
Compare
besmpl
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject nil Vulkan render and compute pipeline layouts before building native pipeline descriptors. The native HAL does not derive automatic layouts, so forwarding VK_NULL_HANDLE is invalid and can crash drivers rather than return a VkResult.
This extracts the independent Vulkan correctness fix from #253 and closes the same pre-FFI hazard for both pipeline types. It contains no prepared-indexed, MDI, Hearth, or module-path changes.
Verification