Skip to content

fix(dx12): match indirect descriptor ABI size #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kolkov merged 1 commit into from
Jul 16, 2026
Merged

fix(dx12): match indirect descriptor ABI size #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion hal/dx12/d3d12/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,11 @@ type D3D12_COMMAND_SIGNATURE_DESC struct {
type D3D12_INDIRECT_ARGUMENT_DESC struct {
Type D3D12_INDIRECT_ARGUMENT_TYPE
// Union for different argument types
Union [8]byte
// The largest member (D3D12_INDIRECT_ARGUMENT_DESC_CONSTANT) is three
// uint32 values, so the C union occupies 12 bytes and the full descriptor
// is 16 bytes including Type. Keeping the exact size matters because
// CreateCommandSignature reads the native descriptor layout directly.
Union [12]byte
}

// D3D12_DISCARD_REGION describes a discard region.
Expand Down
17 changes: 17 additions & 0 deletions hal/dx12/d3d12/types_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
//go:build windows && !(js && wasm)

package d3d12

import (
"testing"
"unsafe"
)

func TestIndirectArgumentDescABI(t *testing.T) {
if got := unsafe.Sizeof(D3D12_INDIRECT_ARGUMENT_DESC{}); got != 16 {
t.Fatalf("D3D12_INDIRECT_ARGUMENT_DESC size = %d, want 16", got)
}
if got := unsafe.Offsetof(D3D12_INDIRECT_ARGUMENT_DESC{}.Union); got != 4 {
t.Fatalf("D3D12_INDIRECT_ARGUMENT_DESC.Union offset = %d, want 4", got)
}
}
Loading