Skip to content

feat: add pre-commit hook config#19

Merged
ldez merged 2 commits intogolangci:masterfrom
VannTen:pre-commit-config
Jun 7, 2024
Merged

feat: add pre-commit hook config#19
ldez merged 2 commits intogolangci:masterfrom
VannTen:pre-commit-config

Conversation

@VannTen
Copy link
Copy Markdown

@VannTen VannTen commented May 22, 2024

This ports client9#174, with some modifications:

  • autofix by default in the pre-commit hook (with -w)
  • don't limit on which files the hook is run by default (let users add limits if necessary).
  • Add usage documentation

I put v0.6.0 in the docs because I suppose this would be a new minor release, but this can be changed if you only want to put it in a patch release.

scop and others added 2 commits May 22, 2024 09:59
Use -w by default so that the pre-commit hook works like an autofixer.

Co-Authored-By: Max Gautier <mg@max.gautier.name>
@ldez ldez added the enhancement New feature or request label May 22, 2024
@ldez ldez self-requested a review May 22, 2024 16:22
@ldez ldez changed the title Add pre-commit hook config feat: add pre-commit hook config Jun 7, 2024
Copy link
Copy Markdown
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez enabled auto-merge (squash) June 7, 2024 23:34
@ldez ldez disabled auto-merge June 7, 2024 23:35
@ldez ldez merged commit 528d713 into golangci:master Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants