Conversation
Some of the tools used during the image creation process were executed based on their absolute path (eg. /sbin), which might not be the case. Changed them to just use the executable's name. Changed scripts shebang to use the more generic `#!/usr/bin/env bash` to accomodate different OSes.
szatanjl
suggested changes
Dec 31, 2024
| @@ -1,3 +1,4 @@ | |||
| .PHONY: all clean | |||
There was a problem hiding this comment.
Since we are adding PHONY then let's add all PHONY targets. I believe targets root, image, iso are PHONY as well
Puts grub-install of the create-live-image.sh script before the system partitions are unmounted. Previously, the installation step happened when the work/mnt directory had the config partition mounted, instead of the root filesystem. Adds --root-directory flag to grub-install, making GRUB scan only the loopback device's partition. Previously, with this option missing, host system was scanned and the LiveUSB would not work if built on one system and booted on a different one. Both of those changes make it possible to actually boot the image, tested using QEMU.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the tools used during the image creation process were executed based on their absolute path (eg. /sbin), which might not be the case. Changed them to just use the executable's name.
Changed scripts shebang to use the more generic
#!/usr/bin/env bashto accomodate different OSes.