Skip to content

chore: Preserve X-GDC-TRACE-ID header for proxied reqs #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinnaj merged 1 commit into from
Apr 2, 2026
Merged

chore: Preserve X-GDC-TRACE-ID header for proxied reqs #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.11.0] - 2026-04-02

### Changed
- `X-GDC-TRACE-ID` response header is now preserved in proxy and record modes (previously stripped along with all `X-GDC*` headers)
- In record mode, `X-GDC-TRACE-ID` is only forwarded to the client — it is still excluded from saved mappings to keep recordings clean

## [0.10.0] - 2026-03-18

### Changed
Expand Down Expand Up @@ -119,6 +125,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added
- Initial release

[0.11.0]: https://github.com/gooddata/gooddata-goodmock/compare/v0.10.0...v0.11.0
[0.10.0]: https://github.com/gooddata/gooddata-goodmock/compare/v0.9.0...v0.10.0
[0.9.0]: https://github.com/gooddata/gooddata-goodmock/compare/v0.8.0...v0.9.0
[0.8.0]: https://github.com/gooddata/gooddata-goodmock/compare/v0.7.0...v0.8.0
Expand Down
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.10.0
0.11.0
5 changes: 4 additions & 1 deletion internal/pureproxy/pureproxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,10 @@ func forwardAndRespond(ps *ProxyServer, ctx *fasthttp.RequestCtx) {
// Send response back to client, filtering headers
for key, values := range respHeaders {
upperKey := strings.ToUpper(key)
if strings.HasPrefix(upperKey, "X-GDC") || upperKey == "DATE" {
if upperKey == "DATE" {
continue
}
if strings.HasPrefix(upperKey, "X-GDC") && upperKey != "X-GDC-TRACE-ID" {
continue
}
if upperKey == "CONTENT-ENCODING" {
Expand Down
5 changes: 4 additions & 1 deletion internal/record/record.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,10 @@ func proxyAndRecord(rs *RecordServer, ctx *fasthttp.RequestCtx) {
// Send response back to client, filtering headers
for key, values := range respHeaders {
upperKey := strings.ToUpper(key)
if strings.HasPrefix(upperKey, "X-GDC") || upperKey == "DATE" {
if upperKey == "DATE" {
continue
}
if strings.HasPrefix(upperKey, "X-GDC") && upperKey != "X-GDC-TRACE-ID" {
continue
}
// Skip Content-Encoding since we decompressed
Expand Down
Loading