You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
TLDR: added common variables (RUFF - path, ROOT_DIR) , fix naming scheme for commands, format and check are ortogonal = two separate commands (neither is subset of the other), project_common.mk for individual packages and Makefile for all.
Unified naming scheme - each command is supposed to do the thing they are named as.
Renamed format (check mode) to format-check for clarity
Removed duplicate import sorting step from format-fix (was running ruff check --fix --fixable I) since lint-fix does it automatically via the --fix tag.
Combined format and format-fix targets (both now run ruff format) = running either of commands changes the code (kept format-fix for mcp ruler). For checking use format-check
tychtjan
changed the title
fix: (MCP ruler) fix lint and lint-fix for python validation
fix: (MCP ruler) unifying lint(-fix), format, check for python validation
Dec 3, 2025
tychtjan
changed the title
fix: (MCP ruler) unifying lint(-fix), format, check for python validation
fix: (MCP ruler) unifying lint, format, check for python validation
Dec 3, 2025
format is set to be Checking only but the name is suggesting that it is formating format-fix is set to be Formating and yes the name is suggesting that it is fixing formatting
So here the question is if even here i should do that the format command is Checking only, but is seems to be more intuitive to let format do Formatting (format-fix as well), and format-check will be Checking only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: GDAI-996
risk: low