[bot] Merge master/a21f8547 into rel/dev#1637
Merged
Merged
Conversation
Update the lint and type dev tooling to their latest patch/dev releases so local checks and CI run against current ruff/ty behavior. uv.lock regenerated to resolve ruff 0.15.15 and ty 0.0.40. The stricter ty 0.0.40 surfaced four latent type issues; fix them so `make types` stays green: - gooddata-pandas series.py: isinstance(granularity, list) narrows the bare list to list[object], making the dict comprehension dict[str, object]; cast back to list[LabelItemDef] to keep the element type. - gooddata-sdk filter.py: explicitly annotate the three _empty_value_handling attributes as EmptyValueHandling | None so the property return type matches (ty widened the narrowed value to str). - gooddata-sdk dataset.py: drop the now-redundant cast in find_label; ty narrows next(filter(...), None) correctly without it. - gooddata-pipelines logger.py: SingletonMeta.__call__ returned "SingletonMeta", typing every LogObserver() as the metaclass; make it generic (cls: type[_T]) -> _T and use type.__call__(cls, ...). jira: trivial risk: nonprod
chore: bump ruff to ~=0.15.15 and ty to ~=0.0.40
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1637 +/- ##
===========================================
- Coverage 79.10% 79.10% -0.01%
===========================================
Files 231 231
Lines 15717 15718 +1
===========================================
Hits 12433 12433
- Misses 3284 3285 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to a21f854 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/26753478737).