fix: shellcheck warnings in scripts

[scidomino]

Summary

Fixes a bunch of shellcheck warnings.

[github-actions]

Size Change: -4 B (0%)

Total Size: 26.4 MB

Filename	Size	Change
./bundle/chunk-2N7WEEJR.js	0 B	-14.7 MB (removed)	🏆
./bundle/chunk-OPYUX3T5.js	0 B	-3.77 MB (removed)	🏆
./bundle/core-KOXDX2QW.js	0 B	-44.1 kB (removed)	🏆
./bundle/devtoolsService-HL6ALU5N.js	0 B	-28.4 kB (removed)	🏆
./bundle/interactiveCli-ZN6HIEAK.js	0 B	-1.63 MB (removed)	🏆
./bundle/oauth2-provider-W4K4UF37.js	0 B	-9.16 kB (removed)	🏆
./bundle/chunk-3PGEXYHJ.js	3.77 MB	+3.77 MB (new file)	🆕
./bundle/chunk-5RT76XG6.js	14.7 MB	+14.7 MB (new file)	🆕
./bundle/core-SJC2ND4J.js	44.1 kB	+44.1 kB (new file)	🆕
./bundle/devtoolsService-MXR3TKIQ.js	28.4 kB	+28.4 kB (new file)	🆕
./bundle/interactiveCli-XPLWE63G.js	1.63 MB	+1.63 MB (new file)	🆕
./bundle/oauth2-provider-JSCXWYTX.js	9.16 kB	+9.16 kB (new file)	🆕

ℹ️ View Unchanged

Filename	Size
./bundle/chunk-34MYV7JD.js	2.45 kB
./bundle/chunk-5AUYMPVF.js	858 B
./bundle/chunk-664ZODQF.js	124 kB
./bundle/chunk-DAHVX5MI.js	206 kB
./bundle/chunk-IUUIT4SU.js	56.5 kB
./bundle/chunk-RJTRUG2J.js	39.8 kB
./bundle/chunk-TMYX6EC6.js	1.96 MB
./bundle/chunk-U4FACSVX.js	1.13 kB
./bundle/devtools-36NN55EP.js	696 kB
./bundle/dist-T73EYRDX.js	356 B
./bundle/events-CLX3JQHP.js	418 B
./bundle/gemini.js	532 kB
./bundle/getMachineId-bsd-TXG52NKR.js	1.55 kB
./bundle/getMachineId-darwin-7OE4DDZ6.js	1.55 kB
./bundle/getMachineId-linux-SHIFKOOX.js	1.34 kB
./bundle/getMachineId-unsupported-5U5DOEYY.js	1.06 kB
./bundle/getMachineId-win-6KLLGOI4.js	1.72 kB
./bundle/memoryDiscovery-2BVFVYWL.js	922 B
./bundle/multipart-parser-KPBZEGQU.js	11.7 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js	222 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js	229 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js	13.4 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js	132 B
./bundle/sandbox-macos-permissive-open.sb	890 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB
./bundle/sandbox-macos-strict-open.sb	4.82 kB
./bundle/sandbox-macos-strict-proxied.sb	5.02 kB
./bundle/src-QVCVGIUX.js	47 kB
./bundle/tree-sitter-7U6MW5PS.js	274 kB
./bundle/tree-sitter-bash-34ZGLXVX.js	1.84 MB

_{compressed-size-action}

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the quality and reliability of the repository's shell scripts by addressing various warnings identified by Shellcheck. The changes ensure safer variable handling, better cross-platform compatibility, and more robust error checking throughout the script execution lifecycle.

Highlights

• Shellcheck Compliance: Updated shell scripts to adhere to Shellcheck best practices, including quoting variables, using array-based command arguments, and switching to more robust conditional syntax.
• Portability Improvements: Enhanced script portability by replacing platform-specific checks with more generic commands and adding proper error handling for temporary file creation.
• Code Robustness: Added explicit shellcheck disable directives where necessary and improved command execution safety to prevent unexpected failures.

Ignored Files

• Ignored by pattern: .gemini/** (2)
  • .gemini/skills/async-pr-review/scripts/async-review.sh
  • .gemini/skills/async-pr-review/scripts/check-async-review.sh

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors scripts/harvest_api_reliability.sh and scripts/review.sh to enhance script robustness and maintainability. The changes standardize variable expansion using curly braces, migrate to [[ ]] for conditional tests, and implement more reliable OS detection via uname. Additionally, the review.sh script features improved temporary file handling and build-status verification. I have no feedback to provide.