Fix #27: Align PyTorch TabFM max_classes default with checkpoint config#50
Open
Paramveersingh-S wants to merge 1 commit into
Open
Fix #27: Align PyTorch TabFM max_classes default with checkpoint config#50Paramveersingh-S wants to merge 1 commit into
Paramveersingh-S wants to merge 1 commit into
Conversation
Paramveersingh-S
requested review from
abhidas,
erzel,
rajatsen91,
siriuz42,
tamannarayan and
weihaokong
as code owners
July 4, 2026 16:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #27.
Description:
The
max_classesconfiguration fortabfm_v1_0_0is correctly defined as10across the codebase (e.g., in the JAX model and the model checkpoints). However, the default constructor arguments for the PyTorchTabFMclass were mistakenly set tomax_classes=3.This PR updates the default PyTorch
max_classesinitialization parameter to10so that it seamlessly aligns with the JAX implementation and the pre-trained HuggingFace checkpoint settings.