fix: pre-merge stateDelta before onUserMessageCallback in Runner#1230
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_921350398
branch
5 times, most recently
from
5012ad9 to
aab0f29
Compare
Previously, stateDelta passed to runAsync was merged into the session only after pluginManager.onUserMessageCallback was invoked, so plugins observed a stale session state during the user-message callback. PiperOrigin-RevId: 922634688
copybara-service
Bot
force-pushed
the
test_921350398
branch
from
aab0f29 to
f1155ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: pre-merge stateDelta before onUserMessageCallback in Runner
Previously, stateDelta passed to runAsync was merged into the session
only after pluginManager.onUserMessageCallback was invoked, so plugins
observed a stale session state during the user-message callback.