fix(otel): prevent contextvars leak across async generators (#5722)#5725
Open
chriskinzel wants to merge 2 commits into
Open
fix(otel): prevent contextvars leak across async generators (#5722)#5725chriskinzel wants to merge 2 commits into
chriskinzel wants to merge 2 commits into
Conversation
rohityan
added
core
Collaborator
|
Hi @chriskinzel , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Can you please fix the failing unit tests before we can proceed with the review. |
aabmass
reviewed
May 19, 2026
Comment on lines
+292
to
+296
| token = context.attach(caller_ctx) | ||
| try: | ||
| yield event | ||
| finally: | ||
| context.detach(token) |
Member
There was a problem hiding this comment.
This looks like it's doing the opposite of what's proposed in #5722 (comment) (attaching before yield, not before).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5722. Explicitly manage OpenTelemetry context attachment and detachment around generator yield boundaries using context.attach and context.detach to prevent span context leaks across coroutine boundaries.