Skip to content

fix(sessions): add universal deduplication check in InMemorySessionService (#5723) #5727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chriskinzel wants to merge 2 commits into
base: main
Choose a base branch
from
+25 −0
Open

fix(sessions): add universal deduplication check in InMemorySessionService (#5723) #5727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcd16b7
fix(sessions): add universal deduplication check in InMemorySessionSe…
May 16, 2026
6a6f27e
Merge branch 'main' into fix-session-deduplication
rohityan May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/google/adk/sessions/in_memory_session_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,8 @@ def _delete_session_impl(

@override
async def append_event(self, session: Session, event: Event) -> Event:
if any(e.id == event.id for e in session.events):
return event
if event.partial:
return event

Expand Down
23 changes: 23 additions & 0 deletions tests/unittests/sessions/test_session_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,6 +763,29 @@ async def test_session_last_update_time_updates_on_event(session_service):
assert refreshed_session.last_update_time > original_update_time


@pytest.mark.asyncio
async def test_append_event_deduplication():
session_service = InMemorySessionService()
app_name = 'my_app'
user_id = 'user'

session = await session_service.create_session(
app_name=app_name, user_id=user_id
)
event = Event(
id='event_id_1',
invocation_id='invocation',
author='user',
timestamp=123456789.0,
)
await session_service.append_event(session=session, event=event)
assert len(session.events) == 1

# Append the same event again
await session_service.append_event(session=session, event=event)
assert len(session.events) == 1


@pytest.mark.asyncio
async def test_append_event_to_stale_session():
session_service = get_session_service(
Expand Down
Loading