Skip to content

test(models): re-enable finish_reason unknown-maps-to-OTHER litellm test #6303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anxkhn wants to merge 2 commits into
base: main
Choose a base branch
from
+0 −1
Open

test(models): re-enable finish_reason unknown-maps-to-OTHER litellm test #6303

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8f93b3
test(models): re-enable finish_reason unknown-maps-to-OTHER litellm test
anxkhn Jul 4, 2026
ae2a868
Merge branch 'main' into test/reenable-litellm-finish-reason-other
rohityan Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tests/unittests/models/test_litellm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4984,7 +4984,6 @@ def test_model_response_to_generate_content_response_safety_finish_reason():
assert llm_response.error_message == "Finished with SAFETY"


@pytest.mark.skip(reason="LiteLLM finish_reason mapping behaviour changed")
@pytest.mark.asyncio
async def test_finish_reason_unknown_maps_to_other(
mock_acompletion, lite_llm_instance
Expand Down
Loading