Skip to content

fix(bigtable): correct get_bigtable_data_client return annotation #6313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anxkhn wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −1
Open

fix(bigtable): correct get_bigtable_data_client return annotation #6313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea0a37c
fix(bigtable): correct get_bigtable_data_client return annotation
anxkhn Jul 4, 2026
0a36bbf
Merge branch 'main' into fix/bigtable-client-return-annotation
rohityan Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/google/adk/tools/bigtable/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def _get_client_info() -> google.api_core.client_info.ClientInfo:

def get_bigtable_data_client(
*, project: str, credentials: Credentials
) -> bigtable.BigtableDataClient:
) -> data.BigtableDataClient:
"""Get a Bigtable client."""

bigtable_data_client = data.BigtableDataClient(
Expand Down
8 changes: 8 additions & 0 deletions tests/unittests/tools/bigtable/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,12 @@
# See the License for the specific language governing permissions and
# limitations under the License.

import typing
from unittest import mock

from google.adk.tools.bigtable import client
from google.auth.credentials import Credentials
from google.cloud.bigtable import data


def test_get_bigtable_data_client():
Expand Down Expand Up @@ -48,3 +50,9 @@ def test_get_bigtable_admin_client():
credentials=mock_creds,
client_info=mock.ANY,
)


def test_get_bigtable_data_client_return_annotation_resolves():
"""The data client return annotation must resolve to a real type."""
hints = typing.get_type_hints(client.get_bigtable_data_client)
assert hints["return"] is data.BigtableDataClient
Loading