Skip to content

refactor(agents): Improve transfer type safety #6324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdabydeen wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −11
Open

refactor(agents): Improve transfer type safety #6324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions src/google/adk/flows/llm_flows/agent_transfer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
from __future__ import annotations

import typing
from typing import Any
from typing import AsyncGenerator
from typing import Sequence

from typing_extensions import override

Expand All @@ -30,8 +30,8 @@
from ._base_llm_processor import BaseLlmRequestProcessor

if typing.TYPE_CHECKING:
from ...agents import BaseAgent
from ...agents import LlmAgent
from ...agents.base_agent import BaseAgent
from ...agents.llm_agent import LlmAgent


class _AgentTransferLlmRequestProcessor(BaseLlmRequestProcessor):
Expand Down Expand Up @@ -72,8 +72,7 @@ async def run_async(
request_processor = _AgentTransferLlmRequestProcessor()


def _build_target_agents_info(target_agent: Any) -> str:
# TODO: Refactor the annotation of the parameters
def _build_target_agents_info(target_agent: BaseAgent) -> str:
return f"""
Agent name: {target_agent.name}
Agent description: {target_agent.description}
Expand All @@ -85,17 +84,16 @@ def _build_target_agents_info(target_agent: Any) -> str:

def _build_transfer_instruction_body(
tool_name: str,
target_agents: list[Any],
target_agents: Sequence[BaseAgent],
) -> str:
"""Build the core transfer instruction text.
TODO: Refactor the annotation of the parameters

This is the agent-tree-agnostic portion of transfer instructions. It
works with any objects having ``.name`` and ``.description`` attributes
works with any BaseAgent implementation.

Args:
tool_name: The name of the transfer tool (e.g. 'transfer_to_agent').
target_agents: Objects with ``.name`` and ``.description``.
target_agents: Agents available as transfer targets.

Returns:
Instruction text for the LLM about agent transfers.
Expand Down Expand Up @@ -128,8 +126,8 @@ def _build_transfer_instruction_body(

def _build_transfer_instructions(
tool_name: str,
agent: 'LlmAgent',
target_agents: list['BaseAgent'],
agent: LlmAgent,
target_agents: Sequence[BaseAgent],
) -> str:
"""Build instructions for agent transfer (agent-tree variant).

Expand Down