Split apart //cuttlefish/process:command_subprocess#2855
Open
Databean wants to merge 8 commits into
Open
Conversation
This was in command_subprocess.* but only had one caller which was in a different file. Bug: b/533572315
Bug: b/533572315
Bug: b/533572315
Bug: b/533572315
This did not have interactions with anything else in Subprocess. Bug: b/533572315
Bug: b/533572315
All other re-exported headers have been removed. Bug: b/533572315
Bug: b/533572315
jemoreira
approved these changes
Jul 14, 2026
| int Execute(std::vector<std::string> commands); | ||
|
|
||
| /** | ||
| * Similar as the two above but returns CF_ERR instead of -1, and siginfo_t |
| * For now, too many callsites expects int, and needs quite a lot of changes | ||
| * if we change the return type. | ||
| */ | ||
| int Execute(std::vector<std::string> commands); |
Member
There was a problem hiding this comment.
nit: The parameter should be named command, otherwise it gives the impression that many subprocesses will run.
Comment on lines
+29
to
+31
| kStopFailure, /* Failed to stop the subprocess. */ | ||
| kStopCrash, /* Attempted to stop the subprocess cleanly, but that failed. */ | ||
| kStopSuccess, /* The subprocess exited in the expected way. */ |
Member
There was a problem hiding this comment.
nit: Stop is redundant in these names, consider:
kFailure,
kCrash,
kSuccess,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was formerly
//cuttlefish/common/libs/utils:subprocess, and is now broken apart.Bug: b/533572315