Skip to content

Fix UI form parsing that created invalid FuzzerJob entries #5381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dylanjew merged 2 commits into from
Jul 24, 2026
+20 −1
Merged

Fix UI form parsing that created invalid FuzzerJob entries #5381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a048d85
Fix UI form parsing that created ghost fuzzer entries
dylanjew Jul 23, 2026
ff9cdb0
Add test
dylanjew Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/appengine/handlers/jobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,8 @@ def post(self):
'Job name can only contain letters, numbers, dashes and underscores.',
400)

fuzzers = request.form.get('fuzzers', []).split(',')
fuzzers_string = request.form.get('fuzzers')
fuzzers = fuzzers_string.split(',') if fuzzers_string else []
templates = request.form.get('templates', '').splitlines()
for template in templates:
if not data_types.JobTemplate.query(
Expand Down
18 changes: 18 additions & 0 deletions src/clusterfuzz/_internal/tests/appengine/handlers/jobs_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,3 +222,21 @@ def test_post(self):
self.assertEqual(200, resp.status_int)
self.mock.update_mappings_for_job.assert_called_with(
mock.ANY, ['test_fuzzer'])

def test_post_empty_fuzzers(self):
"""Test post method with no fuzzers provided."""
self.mock.has_access.return_value = True
job = self._create_job('test_job', 'PROJECT_NAME = proj\n')

resp = self.app.post(
'/', {
'csrf_token': form.generate_csrf_token(),
'name': job.name,
'desciption': job.description,
'platform': job.platform,
'fuzzers': ''
},
expect_errors=True)

self.assertEqual(200, resp.status_int)
self.mock.update_mappings_for_job.assert_called_with(mock.ANY, [])
Loading