Skip to content

Validate vertex indices in GetParallelogramEntries #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TristanInSec wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −3
Open

Validate vertex indices in GetParallelogramEntries #1191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions ...o/compression/attributes/prediction_schemes/mesh_prediction_scheme_parallelogram_shared.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,27 @@ inline void GetParallelogramEntries(
// One vertex of the input |table| correspond to exactly one attribute value
// entry. The |table| can be either CornerTable for per-vertex attributes,
// or MeshAttributeCornerTable for attributes with interior seams.
*opp_entry = vertex_to_data_map[table->Vertex(ci).value()];
*next_entry = vertex_to_data_map[table->Vertex(table->Next(ci)).value()];
*prev_entry = vertex_to_data_map[table->Vertex(table->Previous(ci)).value()];
const VertexIndex vert_opp = table->Vertex(ci);
const VertexIndex vert_next = table->Vertex(table->Next(ci));
const VertexIndex vert_prev = table->Vertex(table->Previous(ci));
if (vert_opp == kInvalidVertexIndex || vert_next == kInvalidVertexIndex ||
vert_prev == kInvalidVertexIndex) {
*opp_entry = -1;
*next_entry = -1;
*prev_entry = -1;
return;
}
if (vert_opp.value() >= vertex_to_data_map.size() ||
vert_next.value() >= vertex_to_data_map.size() ||
vert_prev.value() >= vertex_to_data_map.size()) {
*opp_entry = -1;
*next_entry = -1;
*prev_entry = -1;
return;
}
*opp_entry = vertex_to_data_map[vert_opp.value()];
*next_entry = vertex_to_data_map[vert_next.value()];
*prev_entry = vertex_to_data_map[vert_prev.value()];
}

// Computes parallelogram prediction for a given corner and data entry id.
Expand Down