Skip to content

fix(B602): replace shell=True with shlex.split() in test_cli.py #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yabets4 wants to merge 1 commit into from
Closed

fix(B602): replace shell=True with shlex.split() in test_cli.py #448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions libs/executors/tests/end-to-end/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

import json
import pathlib
import shlex
import subprocess
import sys

Expand Down Expand Up @@ -99,8 +100,7 @@ def test_fake_source_from_console(self, command):
'--loglevel ERROR'
)
result = subprocess.run(
command,
shell=True,
shlex.split(command),
check=False,
capture_output=True,
text=True,
Expand All @@ -123,8 +123,7 @@ def test_fake_source_from_file(self, tmp_path, command):
'--loglevel ERROR'
)
result = subprocess.run(
command,
shell=True,
shlex.split(command),
check=False,
capture_output=True,
text=True,
Expand All @@ -146,8 +145,7 @@ def test_fake_source_from_config(self, tmp_path, command):
'--loglevel ERROR'
)
result = subprocess.run(
command,
shell=True,
shlex.split(command),
check=False,
capture_output=True,
text=True,
Expand All @@ -162,8 +160,7 @@ def test_fake_source_from_workflow(self, command):
workflow_path = _SCRIPT_PATH / 'test_workflow.yaml'
command = f'{command} {str(workflow_path)} --loglevel ERROR'
result = subprocess.run(
command,
shell=True,
shlex.split(command),
check=False,
capture_output=True,
text=True,
Expand All @@ -183,8 +180,7 @@ def test_fake_source_from_workflow_with_config(self, command, tmp_path):
f'{command} {str(workflow_path)} --loglevel ERROR -c {str(tmp_config)}'
)
result = subprocess.run(
command,
shell=True,
shlex.split(command),
check=False,
capture_output=True,
text=True,
Expand Down