Migrate TaskView to compose (#3617)

- Refactor data collection task fragments to use Compose-based layout
- Replace `TaskView` and `TaskViewFactory` with a new `TaskViewLayout` Compose component.
- Remove `onCreateTaskView` from `AbstractTaskFragment` and subclasses, replacing it with a `taskHeader` property.
- Update `AbstractTaskFragment` to use `createComposeView` for the entire fragment view, integrating header, body, and footer into a unified `TaskViewLayout`.
- Migrated all task fragments (Text, Date, Number, Photo, MultipleChoice, Time, Instruction, DrawArea, DropPin, CaptureLocation) to the new layout system.
- Introduce `Header` data class to handle task labels and optional icons in a standardized way.
- Refactor LoiNameDialog to be a Composable function within AbstractTaskFragment
- Move `LoiNameDialog` logic from `renderComposableDialog` into a dedicated `@Composable` function.
- Update `onCreateView` to include `LoiNameDialog` when the task is an "Add LOI" task.
- Simplify `handleNext` to trigger the dialog via the `loiNameDialogOpen` state.
- Consolidate dialog state and value handling within the new `LoiNameDialog` component.
- Refactor instructions dialog to use Compose state and centralized layout
- Refactor the self-intersection dialog in `DrawAreaTaskFragment` to use Compose state
- Refactor PhotoTaskFragment to handle permission dialogs using Compose state
- Refactor location permission dialog in CaptureLocationTaskFragment to use Compose
- Refactor `InstructionsDialog` logic into a dedicated Composable in `AbstractTaskFragment`
- Remove unused xml layouts and associated views
- Use compose to reposition the progress bar
- Update `AbstractTaskFragment` to track footer position when keyboard visibility changes

---------

Co-authored-by: Andreia Ferreira <51242456+andreia-ferreira@users.noreply.github.com>

Author: shobhitagarwal1612

app/src/main/java/org/groundplatform/android/ui/datacollection/DataCollectionFragment.kt

@@ -33,7 +33,6 @@ import androidx.navigation.fragment.findNavController
 import androidx.viewpager2.widget.ViewPager2
 import dagger.hilt.android.AndroidEntryPoint
 import javax.inject.Inject
-import kotlinx.coroutines.delay
 import kotlinx.coroutines.launch
 import org.groundplatform.android.R
 import org.groundplatform.android.databinding.DataCollectionFragBinding
@@ -81,19 +80,11 @@ class DataCollectionFragment : AbstractFragment(), BackPressListener {
     viewPager.isUserInputEnabled = false
     viewPager.offscreenPageLimit = 1
 
-    viewPager.registerOnPageChangeCallback(
-      object : ViewPager2.OnPageChangeCallback() {
-        override fun onPageScrollStateChanged(state: Int) {
-          super.onPageScrollStateChanged(state)
-          if (state == ViewPager2.SCROLL_STATE_IDLE) {
-            viewLifecycleOwner.lifecycleScope.launch {
-              delay(100) // Wait for the keyboard to close
-              setProgressBarPosition(view)
-            }
-          }
-        }
+    viewLifecycleOwner.lifecycleScope.launch {
+      viewLifecycleOwner.lifecycle.repeatOnLifecycle(Lifecycle.State.STARTED) {
+        viewModel.footerVerticalPosition.collect { setProgressBarPosition(it) }
       }
-    )
+    }
 
     // Collect UI state safely across the Fragment view lifecycle.
     viewLifecycleOwner.lifecycleScope.launch {
@@ -139,21 +130,15 @@ class DataCollectionFragment : AbstractFragment(), BackPressListener {
     }
   }
 
-  private fun setProgressBarPosition(view: View) {
-    val buttonContainer = view.findViewById<View>(R.id.action_buttons) ?: return
+  private fun setProgressBarPosition(topPosition: Float) {
+    val insets = requireView().rootWindowInsets ?: return
+    val windowInsets = WindowInsetsCompat.toWindowInsetsCompat(insets)
+    val systemBarsInsets = windowInsets.getInsets(WindowInsetsCompat.Type.systemBars())
 
-    buttonContainer.doOnLayout {
-      val anchorLocation = IntArray(2)
-      it.getLocationInWindow(anchorLocation)
+    val guidelineTop = topPosition.toInt() - systemBarsInsets.top
 
-      val windowInsets = WindowInsetsCompat.toWindowInsetsCompat(buttonContainer.rootWindowInsets)
-      val systemBarsInsets = windowInsets.getInsets(WindowInsetsCompat.Type.systemBars())
-
-      val guidelineTop = anchorLocation[1] - systemBarsInsets.top
-
-      if (guidelineTop > 0) {
-        guideline.setGuidelineBegin(guidelineTop)
-      }
+    if (guidelineTop > 0) {
+      guideline.setGuidelineBegin(guidelineTop)
     }
   }
 

app/src/main/java/org/groundplatform/android/ui/datacollection/DataCollectionViewModel.kt

@@ -74,6 +74,10 @@ internal constructor(
   private val dataCollectionInitializer: DataCollectionInitializer,
 ) : AbstractViewModel() {
 
+  /** The current vertical position of the task view footer. */
+  private val _footerVerticalPosition = MutableStateFlow(0.0f)
+  val footerVerticalPosition: StateFlow<Float> = _footerVerticalPosition
+
   private val _uiState = MutableStateFlow<DataCollectionUiState>(DataCollectionUiState.Loading)
   val uiState: StateFlow<DataCollectionUiState> = _uiState
 
@@ -367,6 +371,10 @@ internal constructor(
       .map { (it as? DataCollectionUiState.Ready)?.currentTaskId == taskId }
       .distinctUntilChanged()
 
+  fun updateFooterPosition(top: Float) {
+    _footerVerticalPosition.value = top
+  }
+
   companion object {
     private const val TASK_JOB_ID_KEY = "jobId"
     private const val TASK_LOI_ID_KEY = "locationOfInterestId"

app/src/main/java/org/groundplatform/android/ui/datacollection/components/InstructionsDialog.kt

@@ -15,58 +15,63 @@
  */
 package org.groundplatform.android.ui.datacollection.components
 
-import androidx.compose.foundation.layout.height
-import androidx.compose.foundation.layout.width
+import androidx.compose.foundation.layout.size
 import androidx.compose.material3.AlertDialog
 import androidx.compose.material3.Icon
+import androidx.compose.material3.MaterialTheme
 import androidx.compose.material3.OutlinedButton
 import androidx.compose.material3.Text
 import androidx.compose.runtime.Composable
-import androidx.compose.runtime.mutableStateOf
-import androidx.compose.runtime.remember
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.graphics.vector.ImageVector
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.res.vectorResource
 import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.unit.dp
-import androidx.compose.ui.unit.sp
 import org.groundplatform.android.R
 import org.groundplatform.android.ui.common.ExcludeFromJacocoGeneratedReport
 import org.groundplatform.ui.theme.AppTheme
 
 @Composable
-fun InstructionsDialog(iconId: Int, stringId: Int) {
-  val showDialog = remember { mutableStateOf(true) }
-  if (showDialog.value) {
-    AlertDialog(
-      icon = {
-        Icon(
-          imageVector = ImageVector.vectorResource(id = iconId),
-          contentDescription = "",
-          modifier = Modifier.width(48.dp).height(48.dp),
-        )
-      },
-      title = { Text(text = stringResource(stringId), fontSize = 18.sp) },
-      onDismissRequest = {}, // Prevent dismissing the dialog by clicking outside
-      confirmButton = {}, // Hide confirm button
-      dismissButton = {
-        OutlinedButton(onClick = { showDialog.value = false }) {
-          Text(text = stringResource(R.string.close))
-        }
-      },
-    )
-  }
+fun InstructionsDialog(data: InstructionData, onDismissed: () -> Unit) {
+  AlertDialog(
+    icon = {
+      Icon(
+        imageVector = ImageVector.vectorResource(id = data.iconId),
+        contentDescription = null,
+        modifier = Modifier.size(48.dp),
+      )
+    },
+    title = {
+      Text(text = stringResource(data.stringId), style = MaterialTheme.typography.titleLarge)
+    },
+    onDismissRequest = {}, // Prevent dismissing the dialog by clicking outside
+    confirmButton = {}, // Hide confirm button
+    dismissButton = {
+      OutlinedButton(onClick = onDismissed) { Text(text = stringResource(R.string.close)) }
+    },
+  )
 }
 
+/**
+ * Data class representing the visual elements of an instruction dialog.
+ *
+ * @property iconId The resource ID of the drawable icon to display.
+ * @property stringId The resource ID of the string message to display.
+ */
+data class InstructionData(val iconId: Int, val stringId: Int)
+
 @Composable
 @Preview
 @ExcludeFromJacocoGeneratedReport
 private fun PreviewInstructionsDialog() {
   AppTheme {
     InstructionsDialog(
-      iconId = R.drawable.touch_app_24,
-      stringId = R.string.draw_area_task_instruction,
-    )
+      data =
+        InstructionData(
+          iconId = R.drawable.touch_app_24,
+          stringId = R.string.draw_area_task_instruction,
+        )
+    ) {}
   }
 }