Skip to content

Update saveFooterPosition to only update position if the current task is active#3667

Open
andreia-ferreira wants to merge 4 commits intomasterfrom
andreia/fix-progress-bar-quirks
Open

Update saveFooterPosition to only update position if the current task is active#3667
andreia-ferreira wants to merge 4 commits intomasterfrom
andreia/fix-progress-bar-quirks

Conversation

@andreia-ferreira
Copy link
Copy Markdown
Collaborator

The progress bar was misaligned in some devices, probably due to the fact that, since view pagers preload neighbor fragments, they might also trigger position updates for the footer position. This PR adds a extra check in saveFooterPosition, to make sure that only the current active task's footer drives the guideline

Before:

Screen_recording_20260413_152950.webm

After:

Screen_recording_20260413_152459.webm

@shobhitagarwal1612 PTAL?

@auto-assign auto-assign bot requested a review from gino-m April 13, 2026 13:35
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.62%. Comparing base (3f3f863) to head (9622bcc).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3667   +/-   ##
=========================================
  Coverage     67.61%   67.62%           
- Complexity     1620     1623    +3     
=========================================
  Files           364      364           
  Lines          9129     9133    +4     
  Branches       1169     1171    +2     
=========================================
+ Hits           6173     6176    +3     
- Misses         2305     2306    +1     
  Partials        651      651           
Files with missing lines Coverage Δ
...id/ui/datacollection/tasks/AbstractTaskFragment.kt 79.34% <100.00%> (+0.93%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@shobhitagarwal1612 shobhitagarwal1612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛 🔨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants