Update saveFooterPosition to only update position if the current task is active#3667
Open
andreia-ferreira wants to merge 4 commits intomasterfrom
Open
Update saveFooterPosition to only update position if the current task is active#3667andreia-ferreira wants to merge 4 commits intomasterfrom
andreia-ferreira wants to merge 4 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3667 +/- ##
=========================================
Coverage 67.61% 67.62%
- Complexity 1620 1623 +3
=========================================
Files 364 364
Lines 9129 9133 +4
Branches 1169 1171 +2
=========================================
+ Hits 6173 6176 +3
- Misses 2305 2306 +1
Partials 651 651
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The progress bar was misaligned in some devices, probably due to the fact that, since view pagers preload neighbor fragments, they might also trigger position updates for the footer position. This PR adds a extra check in
saveFooterPosition, to make sure that only the current active task's footer drives the guidelineBefore:
Screen_recording_20260413_152950.webm
After:
Screen_recording_20260413_152459.webm
@shobhitagarwal1612 PTAL?