Migrate DropPinTaskFragment to use TaskScreen Component#3670
Open
shobhitagarwal1612 wants to merge 5 commits intomasterfrom
Open
Migrate DropPinTaskFragment to use TaskScreen Component#3670shobhitagarwal1612 wants to merge 5 commits intomasterfrom
shobhitagarwal1612 wants to merge 5 commits intomasterfrom
Conversation
…implify map gesture logic
… DropPinTaskScreen
shobhitagarwal1612
temporarily deployed
to
e2e-approval
GitHub Actions
Inactive
| } | ||
|
|
||
| override fun renderFeatures(): LiveData<Set<Feature>> = taskViewModel.features | ||
| override fun renderFeatures(): LiveData<Set<Feature>> = taskViewModel.features.asLiveData() |
Collaborator
There was a problem hiding this comment.
can this also be refactored to return a flow instead of LiveData? As far as I see, it's used in onMapReady on AbstractTaskMapFragment which needs to convert it to a flow anyway
|
|
||
| @HiltAndroidTest | ||
| @RunWith(RobolectricTestRunner::class) | ||
| class DropPinTaskViewModelTest : BaseHiltTest() { |
Collaborator
There was a problem hiding this comment.
was this test file removed because the test cases are covered elsewhere? It's worth considering keeping this and adding tests for what isn't covered yet like the initialize logic or the logic triggered by dismissing the instructions dialog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3630
DropPinTaskScreenComposable to handle the UI.DropPinTaskFragmentto usecreateComposeViewand render the newDropPinTaskScreen.DropPinTaskScreen*TaskFragmentTestwith*TaskScreenTestand adds more coverageVerified for regressions by running the app on emulator and verifying the following scenarios:
@andreia-ferreira PTAL?