Standardize license headers and fix ESLint config#2430
Conversation
Summary of ChangesHello @rfontanarosa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing code quality and legal clarity by standardizing license headers throughout the project. It achieves this by integrating a new ESLint plugin to automatically check and enforce the presence and format of Apache 2.0 license headers in TypeScript and JavaScript files. The changes also include necessary updates to the ESLint configuration and development dependencies to support this new enforcement, alongside minor adjustments to package management files. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request successfully introduces eslint-plugin-headers to enforce standardized license headers and improves the NX linting configuration by allowing argument forwarding. However, there are some inconsistencies in the quote style used in the new ESLint configuration, and the license header template uses double quotes which conflicts with the existing single-quote style found in the repository (including the eslint.config.mjs file itself). Additionally, the header check is currently limited to JavaScript and TypeScript files, while the PR title suggests a broader standardization that should likely include HTML files as well.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2430 +/- ##
=======================================
Coverage 60.24% 60.24%
=======================================
Files 115 115
Lines 2830 2830
Branches 425 425
=======================================
Hits 1705 1705
Misses 1064 1064
Partials 61 61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ck-for-copyright-headers # Conflicts: # eslint.config.mjs # pnpm-lock.yaml # pnpm-workspace.yaml # web/package.json
…ck-for-copyright-headers # Conflicts: # pnpm-lock.yaml
…ck-for-copyright-headers
…ck-for-copyright-headers
…ck-for-copyright-headers
closes #1833