Skip to content

Enable ktfmt#3038

Draft
jaschdoc wants to merge 2 commits into
mainfrom
format-with-ktfmt
Draft

Enable ktfmt#3038
jaschdoc wants to merge 2 commits into
mainfrom
format-with-ktfmt

Conversation

@jaschdoc

Copy link
Copy Markdown
Collaborator

Enables ktfmt across the entire repo.

  • Check that build files have not changed except for formatting
  • Check the following source file changes:

Here is a list of changed class files after enabling ktfmt. The corresponding source files should be double-checked. The list is obtained by first compiling KSP without applying ktfmt, then applying ktfmt and recompiling. Then all class files were checked for byte-for-byte equality modulo debug information, i.e., the pseudo predicate compileModuloDebugInfo(ksp) == compileModuloDebugInfo(ktfmt(ksp)) was checked. Thus, these class files were the only ones to differ. Most of the changes seem to be local variable and stack changes, but the source files should be checked just to be sure.

================================================================================
SUMMARY OF ALL CHANGED CLASSES:
================================================================================
 1. com.google.devtools.ksp.cmdline.KSPJvmMainKt [SEMANTIC DIFF]
 2. com.google.devtools.ksp.common.IncrementalContextBase [SEMANTIC DIFF]
 3. com.google.devtools.ksp.common.impl.PsiResolutionStrategy [SEMANTIC DIFF]
 4. com.google.devtools.ksp.impl.KotlinSymbolProcessingKt [NOISE ONLY]
 5. com.google.devtools.ksp.impl.KotlinSymbolProcessing [SEMANTIC DIFF]
 6. com.google.devtools.ksp.impl.ResolverAAImpl [SEMANTIC DIFF]
 7. com.google.devtools.ksp.impl.symbol.java.KSAnnotationJavaImplKt [SEMANTIC DIFF]
 8. com.google.devtools.ksp.impl.symbol.java.KSAnnotationJavaImpl [SEMANTIC DIFF]
 9. com.google.devtools.ksp.impl.symbol.kotlin.AbstractKSDeclarationImpl [SEMANTIC DIFF]
10. com.google.devtools.ksp.impl.symbol.kotlin.KSAnnotationImpl [SEMANTIC DIFF]
11. com.google.devtools.ksp.impl.symbol.kotlin.KSClassDeclarationEnumEntryImpl [SEMANTIC DIFF]
12. com.google.devtools.ksp.impl.symbol.kotlin.KSClassDeclarationImpl$asStarProjectedType$1$1 [NOISE ONLY]
13. com.google.devtools.ksp.impl.symbol.kotlin.KSClassDeclarationImpl$special$$inlined$lazyMemoizedSequence$1 [NOISE ONLY]
14. com.google.devtools.ksp.impl.symbol.kotlin.KSClassDeclarationImpl [SEMANTIC DIFF]
15. com.google.devtools.ksp.impl.symbol.kotlin.KSFunctionDeclarationImpl$special$$inlined$lazyMemoizedSequence$1 [SEMANTIC DIFF]
16. com.google.devtools.ksp.impl.symbol.kotlin.KSFunctionDeclarationImpl [SEMANTIC DIFF]
17. com.google.devtools.ksp.impl.symbol.kotlin.KSPropertyAccessorImpl$special$$inlined$lazyMemoizedSequence$3 [SEMANTIC DIFF]
18. com.google.devtools.ksp.impl.symbol.kotlin.KSPropertyDeclarationImpl$special$$inlined$lazyMemoizedSequence$1 [NOISE ONLY]
19. com.google.devtools.ksp.impl.symbol.kotlin.KSPropertyDeclarationImplKt [NOISE ONLY]
20. com.google.devtools.ksp.impl.symbol.kotlin.KSPropertyDeclarationImpl [SEMANTIC DIFF]
21. com.google.devtools.ksp.impl.symbol.kotlin.KSPropertyDeclarationLocalVariableImpl [SEMANTIC DIFF]
22. com.google.devtools.ksp.impl.symbol.kotlin.KSTypeParameterImpl [SEMANTIC DIFF]
23. com.google.devtools.ksp.impl.symbol.kotlin.KSValueParameterImpl [NOISE ONLY]
24. com.google.devtools.ksp.impl.symbol.kotlin.UtilKt [SEMANTIC DIFF]
25. com.google.devtools.ksp.impl.symbol.kotlin.resolved.KSAnnotationResolvedImpl [SEMANTIC DIFF]
26. com.google.devtools.ksp.impl.symbol.util.BinaryUtilsKt [NOISE ONLY]
27. com.google.devtools.ksp.impl.symbol.util.DeclarationOrdering [NOISE ONLY]
28. com.google.devtools.ksp.impl.symbol.util.PsiUtilsKt [SEMANTIC DIFF]
29. com.google.devtools.ksp.standalone.IncrementalJavaFileManagerKt [NOISE ONLY]

================================================================================
Total changed class files: 29
Total pairs with non-trivial semantic diffs: 20
================================================================================

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant