Enable ktfmt#3038
Draft
jaschdoc wants to merge 2 commits into
Draft
Conversation
jaschdoc
commented
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables
ktfmtacross the entire repo.Here is a list of changed class files after enabling
ktfmt. The corresponding source files should be double-checked. The list is obtained by first compiling KSP without applyingktfmt, then applyingktfmtand recompiling. Then all class files were checked for byte-for-byte equality modulo debug information, i.e., the pseudo predicatecompileModuloDebugInfo(ksp) == compileModuloDebugInfo(ktfmt(ksp))was checked. Thus, these class files were the only ones to differ. Most of the changes seem to be local variable and stack changes, but the source files should be checked just to be sure.