Adding feature to update rules in place rather than having to only create new ones#253
Open
Pavornoc wants to merge 1 commit into
Open
Adding feature to update rules in place rather than having to only create new ones#253Pavornoc wants to merge 1 commit into
Pavornoc wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
update_ruleMCP tool to the SecOps server, filling a gap in the existingrule management workflow.
Currently, the only way to modify an existing YARA-L detection rule via MCP is to
create a new rule and manually clean up the old version.
update_rulewraps theexisting
chronicle.update_rule()client method (PATCHrules/{rule_id}withupdate_mask=text) to replace rule text in place, preserving the rule's ID,deployment state, and version history.
Changes
server/secops/secops_mcp/tools/security_rules.py— newupdate_ruletool,inserted after
create_rule. No existing code modified.server/secops/tests/test_secops_rules_unit.py— new unit test file with 9 testscovering the success path, correct argument forwarding, version string surfacing,
graceful handling of missing API fields, and error propagation.
Notes
secopslibrary already exposesChronicleClient.update_rule(rule_id, rule_text);this PR only adds the MCP tool layer.
replace("rule ", "")approach as
create_rulefor consistency. A fix to both functions would be aseparate follow-on.