chore: Minimum release age of one week#938
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Ah, getting some build failures because |
|
Yes, seems like an npm bug. A few things to note: (1) Neuroglancer has a lot of build-time JavaScript dependencies but very few runtime JavaScript dependencies, and the runtime JavaScript dependencies are unlikely to pose security risks assuming they aren't malicious. The build-time dependencies aren't exposed and therefore only malicious packages are a risk there. Therefore, there is little reason to proactively update dependencies --- instead that can be done just as needed for new functionality. (2) The min-release-age setting is only relevant when updating the lockfile, but I guess npm also just validates it all the time? That is unfortunate because in some case we may want to specifically use a newer version for some reason and we don't want a check failing as a result. |
|
This PR resolves #934 by adding a
min-release-ageof 7 days to the.npmrcfile. It alo updates the minimum Node version to 24, since that's the version that has thenpmCLI with themin-release-agefeature.