Skip to content

fix: load omero metadata for NGFF 0.5 data #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krokicki wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

fix: load omero metadata for NGFF 0.5 data #960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/datasource/zarr/ome.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,7 +729,7 @@ export function parseOmeMetadata(
): OmeMetadata | undefined {
const ome = attrs.ome;
const multiscales = ome == undefined ? attrs.multiscales : ome.multiscales; // >0.4
const omero = attrs.omero;
const omero = ome == undefined ? attrs.omero : ome.omero; // >0.4
Copy link
Copy Markdown
Contributor

@chrisj chrisj Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @krokicki

I think we can clean this section now by using something like

  const {ome} = attrs;
  const metadata = attrs.ome ?? attrs; // >0.4
  const { multiscales, omero } = metadata;

Unfortunately version is not as simple


if (!Array.isArray(multiscales)) return undefined;
const errors: string[] = [];
Expand Down