feat: add lines box render and use in volume rendering to replace old wireframe#990
Open
seankmartin wants to merge 1 commit into
Open
Conversation
Contributor
|
@seankmartin can you share a link with a state that demonstrates the new behavior? |
Contributor
Author
For sure, here is basically what was in the screenshot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New wireframe:
Old wireframe:
The only real drawback I can see from the old is that it doesn't work in max/min projection modes, but I think that trade off is worth it to have a better debug view in one of the modes. Making it work for max/min projection would involve changes that I don't think are worth it for a debug vis