🔒 [security fix] Fix unwrap() panics when converting C strings#354
Conversation
This commit replaces dangerous `unwrap()` calls with safer alternatives when converting C strings to Rust strings. This prevents potential panics if the ICU library returns non-UTF-8 data. - `ULoc::get_available`: Propagates `Utf8Error` via `?`. - `ULoc::iso3_language` & `ULoc::iso3_country`: Uses `to_string_lossy()` to avoid panics while maintaining the return type. Co-authored-by: filmil <246576+filmil@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
test cases? |
| ffi::CStr::from_ptr( | ||
| versioned_function!(uloc_getISO3Language)(self.as_c_str().as_ptr()) | ||
| ).to_str() | ||
| let value = unsafe { |
There was a problem hiding this comment.
Add tests, for this and below.
There was a problem hiding this comment.
Added a test case for ULoc::get_available. I've reverted the changes to iso3_language and iso3_country based on the other feedback, so I haven't added tests for those.
This commit replaces a dangerous `unwrap()` call in `ULoc::get_available` with the `?` operator. This prevents potential panics if the ICU library returns non-UTF-8 data. A test case for `ULoc::get_available` was added to verify the fix. Proactive changes to `iso3_language` and `iso3_country` were reverted per Pull Request feedback. Co-authored-by: filmil <246576+filmil@users.noreply.github.com>
2 participants
🎯 What: The vulnerability fixed is the use of
unwrap()when converting C strings to Rust strings inrust_icu_uloc.🛡️ Solution:
ULoc::get_available,unwrap()is replaced with the?operator to propagate any UTF-8 conversion errors.ULoc::iso3_languageandULoc::iso3_country,to_str().unwrap()is replaced withto_string_lossy()to avoid panics while maintaining the existing API signature.These changes ensure the library is more robust against unexpected input from the underlying C library.
PR created automatically by Jules for task 17310211343422451087 started by @filmil