Skip to content

Remove torch.cholesky overrides #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qihqi merged 3 commits into from
Jul 3, 2026
Merged

Remove torch.cholesky overrides #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de355d2
Remove cholesky from FP32 cast policy
malfet Jun 15, 2026
d067521
Rename cholesky operation to linalg_cholesky
malfet Jun 15, 2026
9e573cb
Fix lint
malfet Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/test_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"_segment_reduce",
"bincount", # NOTE: dtype for int input torch gives float. This is weird.
"byte",
"cholesky", # To be removed from PyTorch, still covered by linalg.cholesky
"cholesky_solve",
"geqrf",
"histogram", # hard op: AssertionError: Tensor-likes are not close!
Expand Down
1 change: 0 additions & 1 deletion torchax/amp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ def autocast(device, dtype=torch.bfloat16, env=None):
torch.ops.aten.grid_sampler_3d.default: CastPolicy.FP32,
torch.ops.aten.trace.default: CastPolicy.FP32,
torch.ops.aten.view_as_complex.default: CastPolicy.FP32,
torch.ops.aten.cholesky.default: CastPolicy.FP32,
torch.ops.aten.cholesky_inverse.default: CastPolicy.FP32,
torch.ops.aten.cholesky_solve.default: CastPolicy.FP32,
torch.ops.aten.inverse.default: CastPolicy.FP32,
Expand Down
2 changes: 1 addition & 1 deletion torchax/ops/jaten.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ def _aten_index_select(x, dim, index):
return jnp.take(x, index, dim)


@op(torch.ops.aten.cholesky)
@op(torch.ops.aten.linalg_cholesky)
def _aten_cholesky(input, upper=False):
return jax.scipy.linalg.cholesky(input, lower=(not upper))

Expand Down