Skip to content

Install rustup from submodule again#1118

Merged
ia0 merged 2 commits into
google:mainfrom
ia0:rustup
Jun 2, 2026
Merged

Install rustup from submodule again#1118
ia0 merged 2 commits into
google:mainfrom
ia0:rustup

Conversation

@ia0
Copy link
Copy Markdown
Member

@ia0 ia0 commented Jun 2, 2026

This reverts #1074.

This is not done for hermetic builds but for source integrity.

This reverts google#1074.

This is not done for hermetic builds but for source integrity.
@ia0 ia0 added the for:security Improves firmware or project security label Jun 2, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates rustup as a git submodule (third_party/rust-lang/rustup) and updates the setup, sync, and upgrade scripts to use this local copy instead of downloading it directly. Feedback on these changes includes initializing RUSTUP_ARGS in scripts/setup.sh to prevent environment leakage, replacing a non-portable GNU sed extension in scripts/sync.sh with a portable pattern for BSD/macOS compatibility, and avoiding the use of eval by executing the static curl command directly.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread scripts/setup.sh
Comment thread scripts/sync.sh
Comment thread scripts/sync.sh
@ia0 ia0 merged commit f37e1b2 into google:main Jun 2, 2026
39 checks passed
@ia0 ia0 deleted the rustup branch June 2, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

for:security Improves firmware or project security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants