Robust and rationalized pass-through removal. #4001
Merged
copybara-service[bot] merged 1 commit intomainfrom Apr 3, 2026
Merged
Robust and rationalized pass-through removal. #4001copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
51e0237 to
5cceb7c
Compare
194522c to
bdac0c1
Compare
Phi input ordering is preserved by explicitly recording the states in which an input is selected by the phi for a parameter in ContinuationInput::choose_in_states. This is filled in using an initial FSM layout on the unoptimized continuation graph. Then, after optimization, the choose_in_states field is used to fill back in NewFSMState::current_inputs_by_input_param. PiperOrigin-RevId: 894119622
bdac0c1 to
af66b5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Robust and rationalized pass-through removal.
Phi input ordering is preserved by explicitly recording the states in which
an input is selected by the phi for a parameter in ContinuationInput::choose_in_states.
This is filled in using an initial FSM layout on the unoptimized continuation graph. Then, after optimization, the choose_in_states field is used to fill back in NewFSMState::current_inputs_by_input_param.