Migrate ac_types to a Bazel module extension.#4017
Merged
copybara-service[bot] merged 1 commit intomainfrom Apr 3, 2026
Merged
Migrate ac_types to a Bazel module extension.#4017copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_890069397
branch
4 times, most recently
from
4d94de4 to
3df4d8e
Compare
copybara-service
bot
changed the title
ac_types to a Bazel module extension.
copybara-service
bot
force-pushed
the
test_890069397
branch
3 times, most recently
from
4a33183 to
de3a74e
Compare
This change moves the `com_github_hlslibs_ac_types` dependency from being loaded in `load_external.bzl` to a dedicated module extension, bringing us another step closer to a WORKSPACE-free world. The biggest change required to make this work: we needed to move from hard-coded include paths to proper use of the Bazel C++ compilation context structures, while filtering out the toolchain's built-in standard libraries. Also, due to the newly-mangled repository names, we had to add a virtual include directory to our unit test framework to ensure the ac_*.h files are correctly found at the expected location. PiperOrigin-RevId: 894149598
copybara-service
bot
force-pushed
the
test_890069397
branch
from
de3a74e to
89e4094
Compare
alirezazd
pushed a commit
to alirezazd/xls-eco
that referenced
this pull request
Apr 13, 2026
…#4038. PiperOrigin-RevId: 894245214
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate ac_types to a Bazel module extension.
This change moves the
com_github_hlslibs_ac_typesdependency from being loaded inload_external.bzlto a dedicated module extension, bringing us another step closer to a WORKSPACE-free world.The biggest change required to make this work: we needed to move from hard-coded include paths to proper use of the Bazel C++ compilation context structures, while filtering out the toolchain's built-in standard libraries.
Also, due to the newly-mangled repository names, we had to add a virtual include directory to our unit test framework to ensure the ac_*.h files are correctly found at the expected location.