fix(bq_driver): Performance improvements SQLColumns#1553
Draft
shivamd-gpartner wants to merge 1 commit into
Draft
fix(bq_driver): Performance improvements SQLColumns#1553shivamd-gpartner wants to merge 1 commit into
shivamd-gpartner wants to merge 1 commit into
Conversation
shivamd-gpartner
force-pushed
the
sql_columns_perf
branch
from
548aa54 to
0ef2dd9
Compare
shivamd-gpartner
force-pushed
the
sql_columns_perf
branch
from
0ef2dd9 to
16e3c6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When both dataset and table names are exact (no wildcards), bypasses full dataset discovery for all tables and views and calls FetchBQTableData directly. When dataset name is exact and case-sensitive, uses it directly instead of calling GetFilteredDatasetIds.
Replaced GetFilteredTables with ListAllTables + client-side regex .
Catalog::GetColumns
simba:
[BENCHMARK] Catalog::GetColumns (Wildcard Column Search) : 2459 ms
our driver:
[BENCHMARK] Catalog::GetColumns (Wildcard Column Search) : 1263 ms
simba:
[BENCHMARK] Catalog::GetColumns (Large Schema Metadata Fetch) : 2985 ms
our driver:
[BENCHMARK] Catalog::GetColumns (Large Schema Metadata Fetch) : 1398 ms
simba:
[BENCHMARK] Catalog::GetColumns (Full Column Metadata Enumeration - FilterTablesOnDefaultDataset=0) : 47,874 ms
[BENCHMARK] Catalog::GetColumns (Full Column Metadata Enumeration - FilterTablesOnDefaultDataset=1) : 7,269 ms
our driver:
[BENCHMARK] Catalog::GetColumns (Full Column Metadata Enumeration - FilterTablesOnDefaultDataset=0) : 49,711 ms
[BENCHMARK] Catalog::GetColumns (Full Column Metadata Enumeration - FilterTablesOnDefaultDataset=1) : 4,358 ms