Skip to content

fix: release builds should upload package after failing integration tests #1587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sachinpro wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −1
Open

fix: release builds should upload package after failing integration tests #1587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/windows-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,8 @@ jobs:
Write-Output "DSN creation completed."

- name: Running testcases
id: tests
continue-on-error: true
shell: bash
run: |
export VCPKG_ROOT="${TEMP}/.build/vcpkg"
Expand Down Expand Up @@ -300,3 +302,10 @@ jobs:
gsutil -m cp `
"$MSI_DIR/$MSI_FILE" `
"gs://$env:GCS_BUCKET/odbc-windows/$arch/$MSI_FILE"

- name: Check test results
if: steps.tests.outcome == 'failure'
shell: bash
run: |
echo "Tests failed!"
exit 1
5 changes: 4 additions & 1 deletion ci/cloudbuild/builds/bq-driver-release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ io::run cmake --build cmake-out
# Copy the roots.pem file to the .so directory to run test cases.
cp /opt/odbc-driver/roots.pem "cmake-out/google/cloud/odbc/roots.pem"
mapfile -t ctest_args < <(ctest::common_args)
io::run env -C cmake-out ctest "${ctest_args[@]}"
TESTS_EXIT_CODE=0
io::run env -C cmake-out ctest "${ctest_args[@]}" || TESTS_EXIT_CODE=$?

io::log_h1 "Packaging and Uploading Driver"

Expand Down Expand Up @@ -112,3 +113,5 @@ io::log "ZIP package created: ${ZIP_NAME}"
export GCS_BUCKET=bq_devtools_release_private
io::log "Uploading ${ZIP_NAME} to gs://${GCS_BUCKET}/drivers/odbc/linux/"
io::run gsutil -m cp "${ZIP_NAME}" "gs://${GCS_BUCKET}/drivers/odbc/linux/"

exit "${TESTS_EXIT_CODE}"
Loading