-
Notifications
You must be signed in to change notification settings - Fork 277
feat: implement agentic identities authentication via cert bound tokens. #1842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
302038f
c21c663
aa70b56
445498c
b083558
5353838
fca1cc8
3bc3933
27dc845
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,287 @@ | ||
| /* | ||
| * Copyright 2025 Google LLC | ||
| * | ||
| * Redistribution and use in source and binary forms, with or without | ||
| * modification, are permitted provided that the following conditions are | ||
| * met: | ||
| * | ||
| * * Redistributions of source code must retain the above copyright | ||
| * notice, this list of conditions and the following disclaimer. | ||
| * * Redistributions in binary form must reproduce the above | ||
| * copyright notice, this list of conditions and the following disclaimer | ||
| * in the documentation and/or other materials provided with the | ||
| * distribution. | ||
| * | ||
| * * Neither the name of Google LLC nor the names of its | ||
| * contributors may be used to endorse or promote products derived from | ||
| * this software without specific prior written permission. | ||
| * | ||
| * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | ||
| * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT | ||
| * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR | ||
| * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT | ||
| * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, | ||
| * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT | ||
| * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, | ||
| * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY | ||
| * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | ||
| * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
| * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
| */ | ||
|
|
||
| package com.google.auth.oauth2; | ||
|
|
||
| import com.google.api.client.json.GenericJson; | ||
| import com.google.api.client.json.JsonObjectParser; | ||
| import com.google.common.annotations.VisibleForTesting; | ||
| import com.google.common.base.Strings; | ||
| import com.google.common.collect.ImmutableList; | ||
| import com.google.common.io.BaseEncoding; | ||
| import java.io.FileInputStream; | ||
| import java.io.IOException; | ||
| import java.io.InputStream; | ||
| import java.nio.charset.StandardCharsets; | ||
| import java.nio.file.Files; | ||
| import java.nio.file.Paths; | ||
| import java.security.GeneralSecurityException; | ||
| import java.security.MessageDigest; | ||
| import java.security.cert.CertificateFactory; | ||
| import java.security.cert.CertificateParsingException; | ||
| import java.security.cert.X509Certificate; | ||
| import java.util.Collection; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.logging.Level; | ||
| import java.util.logging.Logger; | ||
| import java.util.regex.Pattern; | ||
|
|
||
| /** Internal utility class for handling Agent Identity certificate-bound access tokens. */ | ||
| final class AgentIdentityUtils { | ||
| private static final Logger LOGGER = Logger.getLogger(AgentIdentityUtils.class.getName()); | ||
|
|
||
| static final String GOOGLE_API_CERTIFICATE_CONFIG = "GOOGLE_API_CERTIFICATE_CONFIG"; | ||
| static final String GOOGLE_API_PREVENT_AGENT_TOKEN_SHARING_FOR_GCP_SERVICES = | ||
| "GOOGLE_API_PREVENT_AGENT_TOKEN_SHARING_FOR_GCP_SERVICES"; | ||
|
|
||
| private static final List<Pattern> AGENT_IDENTITY_SPIFFE_PATTERNS = | ||
|
vverman marked this conversation as resolved.
|
||
| ImmutableList.of( | ||
| Pattern.compile("^agents\\.global\\.org-\\d+\\.system\\.id\\.goog$"), | ||
| Pattern.compile("^agents\\.global\\.proj-\\d+\\.system\\.id\\.goog$")); | ||
|
vverman marked this conversation as resolved.
|
||
|
|
||
| // Polling configuration | ||
| private static final long TOTAL_TIMEOUT_MS = 30000; // 30 seconds | ||
| private static final long FAST_POLL_DURATION_MS = 5000; // 5 seconds | ||
| private static final long FAST_POLL_INTERVAL_MS = 100; // 0.1 seconds | ||
| private static final long SLOW_POLL_INTERVAL_MS = 500; // 0.5 seconds | ||
|
|
||
| private static final int SAN_URI_TYPE = 6; | ||
| private static final String SPIFFE_SCHEME_PREFIX = "spiffe://"; | ||
|
|
||
| // Interface to allow mocking System.getenv for tests without exposing it publicly. | ||
| interface EnvReader { | ||
| String getEnv(String name); | ||
| } | ||
|
|
||
| private static EnvReader envReader = System::getenv; | ||
|
|
||
| /** | ||
| * Internal interface to allow mocking time and sleep for tests. This is used to prevent tests | ||
| * from running for long periods of time when polling is involved. | ||
| */ | ||
| @VisibleForTesting | ||
| interface TimeService { | ||
| long currentTimeMillis(); | ||
|
|
||
| void sleep(long millis) throws InterruptedException; | ||
| } | ||
|
|
||
| private static TimeService timeService = | ||
| new TimeService() { | ||
| @Override | ||
| public long currentTimeMillis() { | ||
| return System.currentTimeMillis(); | ||
| } | ||
|
|
||
| @Override | ||
| public void sleep(long millis) throws InterruptedException { | ||
| Thread.sleep(millis); | ||
| } | ||
| }; | ||
|
|
||
| private AgentIdentityUtils() {} | ||
|
|
||
| /** | ||
| * Gets the Agent Identity certificate if available and enabled. | ||
|
vverman marked this conversation as resolved.
Outdated
|
||
| * | ||
| * @return The X509Certificate if found and Agent Identities are enabled, null otherwise. | ||
| * @throws IOException If there is an error reading the certificate file after retries. | ||
| */ | ||
| static X509Certificate getAgentIdentityCertificate() throws IOException { | ||
| if (isOptedOut()) { | ||
| return null; | ||
| } | ||
|
|
||
| String certConfigPath = envReader.getEnv(GOOGLE_API_CERTIFICATE_CONFIG); | ||
| if (Strings.isNullOrEmpty(certConfigPath)) { | ||
| return null; | ||
| } | ||
|
|
||
| String certPath = getCertificatePathWithRetry(certConfigPath); | ||
| return parseCertificate(certPath); | ||
| } | ||
|
|
||
| /** Checks if the user has opted out of Agent Token sharing. */ | ||
| private static boolean isOptedOut() { | ||
| String optOut = envReader.getEnv(GOOGLE_API_PREVENT_AGENT_TOKEN_SHARING_FOR_GCP_SERVICES); | ||
| return optOut != null && "false".equalsIgnoreCase(optOut); | ||
| } | ||
|
|
||
| /** Polls for the certificate config file and the certificate file it references. */ | ||
| private static String getCertificatePathWithRetry(String certConfigPath) throws IOException { | ||
| long startTime = timeService.currentTimeMillis(); | ||
| boolean warned = false; | ||
|
|
||
| while (true) { | ||
|
vverman marked this conversation as resolved.
Outdated
|
||
| try { | ||
| if (Files.exists(Paths.get(certConfigPath))) { | ||
| String certPath = extractCertPathFromConfig(certConfigPath); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IIUC, null is used to represent that the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Interesting thought, in that case the cert-config file itself is malformed which I didn't account for.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe the change is made! |
||
| if (!Strings.isNullOrEmpty(certPath) && Files.exists(Paths.get(certPath))) { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is testing that the certPath from certConfig exists, right? I think this would be the happy path. Just want to confirm: What about the test case that the certPath from certConfig doesn't exist on the file system. Should we stop retrying and fail instead of continue to retry?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good question, I will defer to @nbayati's opinion on this:
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To update this -> Before enabling mTLS, we will check whether the GOOGLE_API_CERTIFICATE_CONFIG points to the right file and the certPath pointed to by config file is valid. Which is to say the code won't reach till here if we don't have a valid cert file. |
||
| return certPath; | ||
| } | ||
| } | ||
| } catch (Exception e) { | ||
| // Ignore exceptions during polling and retry | ||
| LOGGER.log(Level.FINE, "Error while polling for certificate files"); | ||
| } | ||
|
vverman marked this conversation as resolved.
Outdated
|
||
|
|
||
| long elapsedTime = timeService.currentTimeMillis() - startTime; | ||
| if (elapsedTime >= TOTAL_TIMEOUT_MS) { | ||
| throw new IOException( | ||
| "Certificate config or certificate file not found after multiple retries. " | ||
| + "Token binding protection is failing. You can turn off this protection by setting " | ||
| + GOOGLE_API_PREVENT_AGENT_TOKEN_SHARING_FOR_GCP_SERVICES | ||
| + " to false to fall back to unbound tokens."); | ||
| } | ||
|
|
||
| if (!warned) { | ||
| LOGGER.warning( | ||
| String.format( | ||
| "Certificate config file not found at %s (from %s environment variable). " | ||
| + "Retrying for up to %d seconds.", | ||
| certConfigPath, GOOGLE_API_CERTIFICATE_CONFIG, TOTAL_TIMEOUT_MS / 1000)); | ||
| warned = true; | ||
|
vverman marked this conversation as resolved.
Outdated
|
||
| } | ||
|
|
||
| try { | ||
| long sleepTime = | ||
| elapsedTime < FAST_POLL_DURATION_MS ? FAST_POLL_INTERVAL_MS : SLOW_POLL_INTERVAL_MS; | ||
| timeService.sleep(sleepTime); | ||
| } catch (InterruptedException e) { | ||
| Thread.currentThread().interrupt(); | ||
| throw new IOException("Interrupted while waiting for certificate files", e); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @SuppressWarnings("unchecked") | ||
| private static String extractCertPathFromConfig(String certConfigPath) throws IOException { | ||
| try (InputStream stream = new FileInputStream(certConfigPath)) { | ||
| JsonObjectParser parser = new JsonObjectParser(OAuth2Utils.JSON_FACTORY); | ||
| GenericJson config = parser.parseAndClose(stream, StandardCharsets.UTF_8, GenericJson.class); | ||
| Map<String, Object> certConfigs = (Map<String, Object>) config.get("cert_configs"); | ||
| if (certConfigs != null) { | ||
| Map<String, Object> workload = (Map<String, Object>) certConfigs.get("workload"); | ||
| if (workload != null) { | ||
| return (String) workload.get("cert_path"); | ||
| } | ||
| } | ||
| } | ||
| return null; | ||
| } | ||
|
|
||
| private static X509Certificate parseCertificate(String certPath) throws IOException { | ||
| try (InputStream stream = new FileInputStream(certPath)) { | ||
| CertificateFactory cf = CertificateFactory.getInstance("X.509"); | ||
| return (X509Certificate) cf.generateCertificate(stream); | ||
| } catch (GeneralSecurityException e) { | ||
| throw new IOException("Failed to parse certificate", e); | ||
| } | ||
| } | ||
|
|
||
| /** Checks if the certificate belongs to an Agent Identity by inspecting SANs. */ | ||
| static boolean shouldRequestBoundToken(X509Certificate cert) { | ||
| try { | ||
| Collection<List<?>> sans = cert.getSubjectAlternativeNames(); | ||
| if (sans == null) { | ||
| return false; | ||
| } | ||
| for (List<?> san : sans) { | ||
| // SAN entry is a list where first element is the type (Integer) and second is value (mostly | ||
| // String) | ||
| if (san.size() >= 2 | ||
| && san.get(0) instanceof Integer | ||
| && (Integer) san.get(0) == SAN_URI_TYPE) { | ||
| Object value = san.get(1); | ||
| if (value instanceof String) { | ||
| String uri = (String) value; | ||
| if (uri.startsWith(SPIFFE_SCHEME_PREFIX)) { | ||
| // Extract trust domain: spiffe://<trust_domain>/... | ||
| String withoutScheme = uri.substring(SPIFFE_SCHEME_PREFIX.length()); | ||
| int slashIndex = withoutScheme.indexOf('/'); | ||
| String trustDomain = | ||
| (slashIndex == -1) ? withoutScheme : withoutScheme.substring(0, slashIndex); | ||
|
|
||
| for (Pattern pattern : AGENT_IDENTITY_SPIFFE_PATTERNS) { | ||
| if (pattern.matcher(trustDomain).matches()) { | ||
| return true; | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } catch (CertificateParsingException e) { | ||
| LOGGER.log(Level.WARNING, "Failed to parse Subject Alternative Names from certificate", e); | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| /** Calculates the SHA-256 fingerprint of the certificate, Base64Url encoded without padding. */ | ||
| static String calculateCertificateFingerprint(X509Certificate cert) throws IOException { | ||
| try { | ||
| MessageDigest md = MessageDigest.getInstance("SHA-256"); | ||
| byte[] der = cert.getEncoded(); | ||
| md.update(der); | ||
| byte[] digest = md.digest(); | ||
| return BaseEncoding.base64Url().omitPadding().encode(digest); | ||
|
vverman marked this conversation as resolved.
Outdated
|
||
| } catch (GeneralSecurityException e) { | ||
| throw new IOException("Failed to calculate certificate fingerprint", e); | ||
| } | ||
| } | ||
|
|
||
| @VisibleForTesting | ||
| static void setEnvReader(EnvReader reader) { | ||
| envReader = reader; | ||
| } | ||
|
|
||
| @VisibleForTesting | ||
| static void setTimeService(TimeService service) { | ||
| timeService = service; | ||
| } | ||
|
|
||
| @VisibleForTesting | ||
| static void resetTimeService() { | ||
| timeService = | ||
| new TimeService() { | ||
| @Override | ||
| public long currentTimeMillis() { | ||
| return System.currentTimeMillis(); | ||
| } | ||
|
|
||
| @Override | ||
| public void sleep(long millis) throws InterruptedException { | ||
| Thread.sleep(millis); | ||
| } | ||
| }; | ||
| } | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.