chore: change to post submit and create an issue on failure#13309
Closed
sofisl wants to merge 3 commits into
Closed
chore: change to post submit and create an issue on failure#13309sofisl wants to merge 3 commits into
sofisl wants to merge 3 commits into
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
JoeWang1127
approved these changes
Jun 1, 2026
zhumin8
requested changes
Jun 1, 2026
Contributor
There was a problem hiding this comment.
Change LGTM. However, I don't think we are ready to merge this now:
- we should to sync librarian.yaml with generation_config.yaml before this, or it will be always failing and creates issues on each PR (see https://github.com/googleapis/google-cloud-java/actions/workflows/librarian_generation_check.yaml).
- Currently, we got generation diff (see #13319) before the release is cut or fix for googleapis/librarian#6244.
Contributor
Author
|
From Min: |
zhumin8
reviewed
Jun 8, 2026
| - name: Check for generated code changes | ||
| run: | | ||
| git diff --exit-code | ||
| - name: Create issue if previous step fails |
Contributor
There was a problem hiding this comment.
Considering current generate all runs for 1 hour +, If one PR is merged causing generation diff, it's likely subsequent PRs are merged. This will create repeating issues. I think we want to combine them to not over-pollute the issue board.
In fact, I believe we can reuse this action from librarian that already does exactly this. https://github.com/googleapis/librarian/tree/main/.github/actions/create-issue-on-failure
Contributor
|
closing in favor of #13422 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the presubmit to a postsubmit check to not delay PRs. Creates issues if necessary. Per googleapis/librarian#5240 (comment).
Fixes 5240