feat: scale up connection worker pool based on latency#13384
Open
agrawal-siddharth wants to merge 1 commit into
Open
feat: scale up connection worker pool based on latency#13384agrawal-siddharth wants to merge 1 commit into
agrawal-siddharth wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a latency-based load metric, timeSinceLastCallback, to ConnectionWorker to track the duration since the oldest in-flight request was sent. This metric is used to determine if a worker is overwhelmed and is integrated into the load comparators for connection routing, with corresponding unit tests added. The review feedback suggests avoiding lock contention in getLoad() by using a volatile timestamp to make the method lock-free, simplifying the comparator bucket calculation using toSeconds(), and maintaining test assertion consistency by using Truth's assertThat instead of JUnit's assertFalse/assertTrue.
GaoleMeng
reviewed
Jun 7, 2026
agrawal-siddharth
force-pushed
the
latency
branch
from
d34cc67 to
de2d8aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.