Skip to content

feat(deps): add jspecify to shared dependencies#13412

Merged
nnicolee merged 1 commit into
googleapis:mainfrom
nnicolee:feat/add-jspecify
Jun 11, 2026
Merged

feat(deps): add jspecify to shared dependencies#13412
nnicolee merged 1 commit into
googleapis:mainfrom
nnicolee:feat/add-jspecify

Conversation

@nnicolee

Copy link
Copy Markdown
Contributor

b/522246866

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the org.jspecify:jspecify dependency (version 1.0.0) to the shared third-party dependencies and includes it in the upper-bound check configuration. There are no review comments, and I have no additional feedback to provide.

@lqiu96 lqiu96 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving following approval from internal ticket

@nnicolee nnicolee added do not merge Indicates a pull request not ready for merge, due to either quality or timing. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jun 10, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 10, 2026
@nnicolee nnicolee marked this pull request as ready for review June 10, 2026 21:37
@nnicolee nnicolee requested review from a team as code owners June 10, 2026 21:37
Comment thread sdk-platform-java/java-shared-dependencies/third-party-dependencies/pom.xml Outdated
@nnicolee nnicolee force-pushed the feat/add-jspecify branch from b01275f to c4e4824 Compare June 11, 2026 20:41
@nnicolee nnicolee merged commit 582053d into googleapis:main Jun 11, 2026
289 of 297 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants