Closed
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
googlebot
added
the
cla: no
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
pmakani
force-pushed
the
google-cloud-java-3707-3708-3728
branch
from
d83f40e to
67f6956
Compare
|
CLAs look good, thanks! |
googlebot
added
cla: yes
…in offline mode. (googleapis#3820) * Added explicit sunfire-junit depency to pull it in for offline mode. Without this dependency explicitly listed java mvn dependency:go-offline will not pull it in and mvn -o verify will not work (Unless the tests have been run in online mode. In this case the cached surefire junit can still be used.) * Adding Surefire depency to bigtable admin and logging as well. * Looks like I need to tell the plugin that it's using the version I'm pulling in. * Looks like the Google Cloud Java Compatibility Checker test require surefire version 2.17 [INFO] Building Google Cloud Java Compatibility Checker 0.67.1-alpha-SNAPSHOT [INFO] ------------------------------------------------------------------------ [WARNING] The POM for org.apache.maven.plugins:maven-surefire-plugin:jar:2.17 is missing, no dependency information available * dependecies is not under build. * Some of the GRPC library need dependencies need surefire 2.17 [INFO] ------------------------------------------------------------------------ [INFO] Building Google Cloud API gRPC 0.32.1-SNAPSHOT [INFO] ------------------------------------------------------------------------ [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Building proto-google-cloud-asset-v1beta1 0.32.1-SNAPSHOT [INFO] ------------------------------------------------------------------------ [WARNING] The POM for org.apache.maven.plugins:maven-surefire-plugin:jar:2.17 is missing, no dependency information available [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Skipping grpc-google-cloud-asset-v1beta1 [INFO] This project has been banned from the build due to previous failures. [INFO] ------------------------------------------------------------------------ [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Building proto-google-cloud-automl-v1beta1 0.32.1-SNAPSHOT [INFO] ------------------------------------------------------------------------ [WARNING] The POM for org.apache.maven.plugins:maven-surefire-plugin:jar:2.17 is missing, no dependency information available [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Skipping grpc-google-cloud-automl-v1beta1 [INFO] This project has been banned from the build due to previous failures. [INFO] ------------------------------------------------------------------------ * Looks like the file path is org.apache.maven.plugins * lets try putting the in utils. It looks like utill uses surefire 2.17 * Looks like spanner uses surefire-junit47 instead of surefire-junit4 * Re-add bigtable admin version * Lets not include spanner with this PR.
suztomo
pushed a commit
that referenced
this pull request
Mar 9, 2026
lqiu96
pushed a commit
that referenced
this pull request
Mar 20, 2026
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3707 #3708 #3728
test-jar in google-cloud-bom
Don't include multiple versions of same API in BOM
Don't bundle tests in jars