Skip to content

fix(ci): test script fixes for node 22 and 26 - #9038

Merged
bshaffer merged 18 commits into
mainfrom
misc-test-fixes
Aug 1, 2026
Merged

fix(ci): test script fixes for node 22 and 26#9038
bshaffer merged 18 commits into
mainfrom
misc-test-fixes

Conversation

@bshaffer

@bshaffer bshaffer commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

misc test fixes needed for #9021 and #8973:

  • Node 22/26 Compatibility: Scoped --no-experimental-require-module specifically to Node v22 in ci/run_conditional_tests.sh so Node v24/v26 ESM imports continue to work with c8.
  • NODE_OPTIONS Preservation: Fixed ci/run_single_test.sh to append to NODE_OPTIONS rather than overwriting it, preserving parent CI environment configurations.

@bshaffer bshaffer changed the title Misc test fixes fix(tests): CI fixes for node 26, bigtable quotas, zizmor Jul 31, 2026
@bshaffer bshaffer changed the title fix(tests): CI fixes for node 26, bigtable quotas, zizmor fix(ci): test fixes for node 26, bigtable quotas, zizmor Jul 31, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates package management and script execution from 'npm' to 'pnpm' across multiple packages, updates test coverage configurations, and enhances 'bigtable' system tests to gracefully handle 'RESOURCE_EXHAUSTED' quota errors and cleanup failures. Additionally, type casting is added to GCS headers to resolve TypeScript compilation issues. The reviewer feedback highlights several redundant nested 'try-catch' blocks in the updated test files that result in dead code, as well as a duplicated 'pnpm' installation command in a CI script.

Comment thread handwritten/bigtable/system-test/read-rows.ts Outdated
Comment thread handwritten/bigtable/system-test/bigtable.ts Outdated
Comment thread handwritten/bigtable/system-test/bigtable.ts Outdated
Comment thread handwritten/bigtable/system-test/app-profile.ts Outdated
Comment thread handwritten/bigtable/system-test/cluster.ts Outdated
Comment thread core/common/.kokoro/release/docs-devsite.sh Outdated
@bshaffer bshaffer changed the title fix(ci): test fixes for node 26, bigtable quotas, zizmor fix(ci): test fixes for node 26, bigtable quotas, zizmor Jul 31, 2026
@bshaffer

Copy link
Copy Markdown
Contributor Author

@gemini-code-assist review please!

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates system tests to handle RESOURCE_EXHAUSTED quota errors gracefully by switching arrow functions to regular functions to support Mocha's this.skip(), adds type assertions to satisfy TypeScript compiler checks, and configures NODE_OPTIONS for Node v22. The review feedback highlights a critical issue where NODE_OPTIONS is overwritten in run_single_test.sh, discarding parent configurations, and identifies several potential resource leaks in bigtable.ts where instances or clusters are not cleaned up if tests fail before the delete calls.

Comment thread ci/run_single_test.sh Outdated
Comment thread handwritten/bigtable/system-test/bigtable.ts Outdated
Comment thread handwritten/bigtable/system-test/bigtable.ts Outdated
Comment thread handwritten/bigtable/system-test/bigtable.ts Outdated
@bshaffer

Copy link
Copy Markdown
Contributor Author

@gemini-code-assist anything else?

@gemini-code-assist

Copy link
Copy Markdown
Contributor

The changes in this pull request look solid and effectively address the CI stability issues, quota handling, and Node 26 compatibility. The use of try-catch blocks to handle RESOURCE_EXHAUSTED errors and gracefully skip tests is a robust approach for managing flaky CI environments.

One minor observation: your PR description mentions pinning actions/cache and actions/github-script to exact hashes for Zizmor compliance, but I don't see any changes to your GitHub Actions workflow files in the provided diffs. If those changes were intended to be part of this PR, please ensure they are included.

Otherwise, the code looks good and ready for merge.

@westarle
westarle self-requested a review July 31, 2026 20:23
westarle

This comment was marked as outdated.

@bshaffer
bshaffer requested a review from westarle July 31, 2026 21:04
@bshaffer
bshaffer marked this pull request as ready for review July 31, 2026 21:05
@bshaffer
bshaffer requested review from a team as code owners July 31, 2026 21:05
Comment thread handwritten/bigtable/system-test/tpc-tests.ts Outdated
@bshaffer bshaffer changed the title fix(ci): test fixes for node 26, bigtable quotas, zizmor fix(ci): test fixes for node 26, bigtable quotas Aug 1, 2026
@bshaffer bshaffer changed the title fix(ci): test fixes for node 26, bigtable quotas fix(ci): test script fixes for node 22 and 26 Aug 1, 2026
@bshaffer
bshaffer enabled auto-merge (squash) August 1, 2026 00:51
@bshaffer
bshaffer merged commit fd65b7f into main Aug 1, 2026
34 checks passed
@bshaffer
bshaffer deleted the misc-test-fixes branch August 1, 2026 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants