Skip to content

chore(build): upgrade Node CI runtimes and remove Node 18 pnpmfile patch #9055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
quirogas wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

chore(build): upgrade Node CI runtimes and remove Node 18 pnpmfile patch #9055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dedb671
chore: update baseline generation
quirogas Jul 31, 2026
09da816
chore(build): upgrade Node CI runtimes and remove Node 18 pnpmfile pa…
quirogas Aug 1, 2026
58cc8bb
chore(build): upgrade Node CI runtimes and remove Node 18 pnpmfile patch
quirogas Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/conformance-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
persist-credentials: false
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 14
node-version: 22
- run: node --version
- run: cd handwritten/storage && npm install
- run: cd handwritten/storage && npm run conformance-test
2 changes: 1 addition & 1 deletion .github/workflows/conformance.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
working-directory: handwritten/bigtable
strategy:
matrix:
node: [ 18, 20 ]
node: [ 20, 22 ]
steps:
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/issues-no-repro.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
persist-credentials: false
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 18
node-version: 22
- run: npm install
working-directory: ./.github/scripts
- uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/mandatory-conformance.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
working-directory: handwritten/bigtable
strategy:
matrix:
node: [ 18, 20 ]
node: [ 20, 22 ]
steps:
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-api-list.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
persist-credentials: false
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 18
node-version: 22
- run: npm install
- run: npm run generate
env:
Expand Down
72 changes: 0 additions & 72 deletions .pnpmfile.cjs
View file
Open in desktop

This file was deleted.

11 changes: 2 additions & 9 deletions ci/run_single_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,8 @@ if [ ${BUILD_TYPE} != "presubmit" ]; then
fi

# Install dependencies
# Normalize POSIX paths to Windows-compatible mixed paths (forward slashes) on Windows Git Bash
# so native Node.js and pnpm processes can resolve .pnpmfile.cjs without segmentation faults.
PNPMFILE_PATH="${PROJECT_ROOT}/.pnpmfile.cjs"
if command -v cygpath >/dev/null 2>&1; then
PNPMFILE_PATH=$(cygpath -m "${PNPMFILE_PATH}")
fi

echo "pnpm install --ignore-scripts --engine-strict --prod --pnpmfile \"${PNPMFILE_PATH}\"; pnpm install --pnpmfile \"${PNPMFILE_PATH}\""
pnpm install --ignore-scripts --engine-strict --prod --pnpmfile "${PNPMFILE_PATH}"; pnpm install --pnpmfile "${PNPMFILE_PATH}"
echo "pnpm install --ignore-scripts --engine-strict --prod; pnpm install"
pnpm install --ignore-scripts --engine-strict --prod; pnpm install


retval=0
Expand Down
2 changes: 1 addition & 1 deletion ...enerator/gapic-generator-typescript/baselines-esm/duplicate_methods_test-esm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,6 @@
"webpack-cli": "^6.0.1"
},
"engines": {
"node": ">=18"
"node": ">=22"
}
Comment on lines 100 to 102

@gemini-code-assist gemini-code-assist Bot Aug 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This file appears to be an auto-generated baseline file. Manually editing auto-generated files is discouraged as these changes will be overwritten during the next regeneration. Please apply the engine constraint updates upstream in the generator or templates, and then regenerate the baselines using the appropriate generation script.

References
  1. Do not manually edit auto-generated files to fix typos or make other changes, as these edits will be overwritten during the next regeneration. Instead, apply the fixes upstream in the generator or templates.

}
2 changes: 1 addition & 1 deletion core/packages/gapic-node-processing/templates/bootstrap-templates/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,6 @@
"typescript": "^5.8.2"
},
"engines": {
"node": ">=18"
"node": ">=22"
}
}
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,6 @@
"prettier": "^3.3.3"
},
"engines": {
"node": ">=18"
"node": ">=20"
}
}
Loading