chore(ci): misc ci fixes, workflow renames, and system test concurrency - #9058
chore(ci): misc ci fixes, workflow renames, and system test concurrency#9058bshaffer wants to merge 10 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces several CI and testing improvements, including test sharding and strict mode support in run_conditional_tests.sh, migration to the standard URL API in nodejs-googleapis-common, and robust error cause handling in gcp-metadata. Feedback on these changes highlights a missing system-test:enterprise:emulator:grpc script in firestore/package.json that was accidentally removed, a potential issue with prematurely unwrapping error causes in gcp-metadata, and the need to initialize the STRICT variable in run_conditional_tests.sh to prevent unbound variable errors.
…ata cause unwrapping, and STRICT init
…est sharding lands
|
@gemini-code-assist please review! |
There was a problem hiding this comment.
Code Review
This pull request introduces several CI and testing improvements, including support for strict mode, dry-run sharding, and test sharding in run_conditional_tests.sh, updated Mocha reporter configurations, and increased test timeouts. It also replaces the deprecated url.parse with new URL in nodejs-googleapis-common, refines error handling in gcp-metadata, and updates instance reaping logic in bigtable system tests. Feedback is provided for gcp-metadata to ensure that nested errors within an AggregateError are also correctly unwrapped to prevent them from resolving to 'UNKNOWN' error codes.
There was a problem hiding this comment.
Can you move this to an independent PR? And include the command you used to generate it?
There was a problem hiding this comment.
I didn't generate it, owlbot generates it and automatically adds it to PRs which don't have it but touch files in the directory (because it's out of date)...
I actually did create a separate PR for it, but since tests fail on it without THIS PR, I thought it was appropriate to put it in this one. Here it is (I closed it, but just reopened it if you'd rather merge it first): #9057
There was a problem hiding this comment.
Thanks for explaining, I don't love Owlbot creating commits.
For now, ideally you could push a commit to #9057 to just breaks caused by owlbot and submit that first.
There was a problem hiding this comment.
I also think it's very strange that owlbot commits directly to branches, and I don't like it at all.
As for #9057, we can just ignore the failing bigtable-system-tests knowing that they'll be fixed by this PR, and merge it.
Note: I think we should disable bigtable-system-tests anyway because they take 90 minutes to run and are flakey. Until they are faster and more reliable they are only slowing us down...
There was a problem hiding this comment.
Thanks for explaining, I don't love Owlbot creating commits.
For now, ideally you could push a commit to #9057 to just breaks caused by owlbot and submit that first.
|
I have broken out this PR into smaller, component-isolated PRs as requested:
|
Misc test improvements and fixes, namely:
conformance-testandconformancetobigtable-conformanceandstorage-conformancerespectively.pack-n-playtest timeouts to 10 minutes and adds--no-audit --no-fundto speed up installs.--no-experimental-require-modulestrictly to Node 22 in CI scripts to prevent ESM crashes on Node 24 and 26.reapInstancescleanup script from deleting active test instances missing atime_createdlabel.endTime = startTime + 1ns) to prevent Cloud MonitoringINVALID_ARGUMENTexport errors.We will be able to comment out triggering all unit tests on
ci/script once the sharding PR (#9021) lands.