-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(firestore): add DML support to pipelines #16473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
8d69f09
feat(firestore): add DML support to pipelines
daniel-sanche 1a981b9
updated yaml
daniel-sanche ee61fa5
fixed unit test
daniel-sanche cd2001b
added assert_proto sections
daniel-sanche e997de8
fixed test parser
daniel-sanche 38755fb
fixed assert_proto
daniel-sanche 814bc5b
updated docstring
daniel-sanche 560bd0b
Apply suggestions from code review
daniel-sanche 8e7fab3
fixed lint
daniel-sanche 8d86c8a
combined end state tests into standard pipeline methods
daniel-sanche 692bfdc
fixed lint
daniel-sanche 910772b
Merge branch 'main' into firestore_pipelines_dml
daniel-sanche 8e592d1
Merge branch 'main' into firestore_pipelines_dml
daniel-sanche 32db995
fixed lint
daniel-sanche a4cb561
fixed yaml argument parsing logic
daniel-sanche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
packages/google-cloud-firestore/tests/system/pipeline_e2e/dml.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| data: | ||
| dml_delete_coll: | ||
| doc1: { score: 10 } | ||
| doc2: { score: 60 } | ||
| dml_update_coll: | ||
| doc1: { status: "pending", score: 50 } | ||
|
|
||
| tests: | ||
| - description: "Basic DML delete" | ||
| pipeline: | ||
| - Collection: dml_delete_coll | ||
| - Where: Field.of("score").less_than(50) | ||
| - Delete: | ||
| assert_end_state: | ||
| dml_delete_coll/doc1: null | ||
| dml_delete_coll/doc2: { score: 60 } | ||
|
|
||
| - description: "Basic DML update" | ||
| pipeline: | ||
| - Collection: dml_update_coll | ||
| - Update: Field.of("status").set("active") | ||
|
daniel-sanche marked this conversation as resolved.
Outdated
|
||
| assert_end_state: | ||
| dml_update_coll/doc1: { status: "active", score: 50 } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.