Change list_secrets to use async await#16477
Change list_secrets to use async await#16477Lucioric2000 wants to merge 1 commit intogoogleapis:mainfrom
Conversation
The list_secrets call returns a coroutine that should be awaited, therefore, I am introducing the await instruction, which was absent, to the async secrets getter example.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request updates the asynchronous sample for listing secrets in the Google Cloud Secret Manager by adding the missing await keyword to the list_secrets method call. This ensures the asynchronous request is properly executed within the async function. I have no feedback to provide.
|
Hey, thanks for putting this together. Unfortunately, this is generated code, and can't be directly modified here. We actually made this fix in the code generator recently though, so you should see it roll out to the library soon |
The list_secrets call returns a coroutine that should be awaited, therefore, I am introducing the await instruction, which was absent, to the async secrets getter example.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕