Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several shell scripts designed to manage secret encryption and decryption via Google Cloud KMS, as well as a setup script for workload identity federation to support integration tests. The review feedback focuses on enhancing the robustness and security of these scripts by recommending the addition of 'set -e' for error handling, quoting variables to prevent word splitting, and replacing hardcoded environment-specific identifiers with environment variables. Additionally, a correction was noted for a directory removal command that was missing the recursive flag.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
| #!/bin/bash | ||
| set -e | ||
|
|
||
| # Copyright 2015 Google Inc. All rights reserved. |
There was a problem hiding this comment.
Nit: Can we update the copyright here and in other places?
parthea
left a comment
parthea
left a comment
There was a problem hiding this comment.
Are the files in the scripts folder used in tests? If not, can we consider adding these to client library maintainer documentation, rather than having unused scripts?
3 participants
Fix failing system tests, related to empty tokens
Also added back scipts from split repo, which were used to set up system tests. These scripts are referenced in CONTRIBUTING.md